Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting right options of command based new connections #23849

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Setting right options of command based new connections #23849

merged 2 commits into from
Jul 13, 2023

Conversation

aasimkhan30
Copy link
Contributor

Previously, right options for command-based connections were not set. Now, I am making the connection type as default so that the connection can be saved in OE.
Issue: #23833

@cheenamalhotra
Copy link
Member

Can you also check group: undefined for dashboard connection when created directly with new connection?
The OE connection now works and clicking Manage does open the dashboard tab with default group id populated - but it seems to be missing when its launched from here.

cheenamalhotra
cheenamalhotra approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@aasimkhan30 aasimkhan30 merged commit 99bf9f2 into main Jul 13, 2023
7 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/23833 branch July 13, 2023 06:58
aasimkhan30 added a commit that referenced this pull request Jul 13, 2023
@aasimkhan30
Setting right options of command based new connections (#23849)
30a6674
@aasimkhan30 aasimkhan30 mentioned this pull request Jul 13, 2023
Merged
kisantia pushed a commit that referenced this pull request Jul 13, 2023
@aasimkhan30
Setting right options of command based new connections (#23849) (#23853)
8e1a288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aasimkhan30 @cheenamalhotra