Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Migration Pre Validation Changes #25897

Merged

Conversation

Bhavikshah123
Copy link
Contributor

Added a new Pre validation dialog that performs the below validations before proceeding to migration. This reduces all the migrations failures that customers are facing today and pre validated beforehand to avoid migration failures and increase the successful migrations.

  1. Validate Sys admin validation- Validates the Sys Admin permission for source and target connection
  2. Validate Entra ID - Validates the Entra ID entered for windows login migration
  3. Validate user mapping -
    Validates the User mapping FOR Target DB existence
    Target DB user existence
    Target DB user with same SID existence

Testing (https://microsoftapc-my.sharepoint.com/:w:/g/personal/bhavikshah_microsoft_com/ER_jJ3YqZXtCoKOfZS4EXRMBY6bvOEGbPP97ltlvS4MNew?e=fawvcw)

  1. Select logins to run validation
  2. Perform validation to run migration
  3. Sysadmin validation: Source doesn't have permissions, but Target has permissions
  4. Sysadmin validation: Source has permission, but Target doesn't have permissions
  5. Sysadmin validation: Source and Target both doesn't have permissions
  6. Entra id validation: Incorrect format
  7. User Mapping: Database not found
  8. User Mapping: Database found but user not found
  9. User Mapping: Database found, user found but userid does not match
  10. Happy path
image

@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10898533139

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 163 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 41.727%

Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/query/common/queryRunner.ts 15 69.71%
src/sql/workbench/services/query/common/queryModelService.ts 148 4.81%
Totals Coverage Status
Change from base Build 10777409214: 0.003%
Covered Lines: 30730
Relevant Lines: 68916

💛 - Coveralls

@Bhavikshah123 Bhavikshah123 merged commit ebe265c into main Sep 17, 2024
12 checks passed
@Bhavikshah123 Bhavikshah123 deleted the user/bhavikshah/loginPreMigrationValidationChanges branch September 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants