[CLI] Fix sourcemap output filename #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/script/command-executor.ts
Outdated
| @@ -1326,8 +1326,8 @@ export const releaseReact = (command: cli.IReleaseReactCommand): Promise<void> = | |||
| ? Q(command.appStoreVersion) | |||
| : getReactNativeProjectAppVersion(command, projectName); | |||
|
|
|||
| if (command.outputDir) { | |||
| command.sourcemapOutput = path.join(command.outputDir, bundleName + ".map"); | |||
| if (command.sourcemapOutput) { | |||
There was a problem hiding this comment.
Can we check if the sourcemapOutput already ends with .map? In that case we don't need adding it manually.
There was a problem hiding this comment.
Thank you for pointing that out! I've updated it.
DmitriyKirakosyan
approved these changes
Nov 20, 2024
lucen-ms
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sourcemapOutput Overwrite
There's an issue where the sourcemap output is overwritten when both the sourcemap output and output directory are used together in the CLI.