Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support net 8 #492

Closed
wants to merge 5 commits into from
Closed

support net 8 #492

wants to merge 5 commits into from

Conversation

WeihanLi
Copy link

@WeihanLi WeihanLi commented Nov 30, 2023

try to support .NET 8

contributes to #491

@pdeligia
Copy link
Member

Super helpful @WeihanLi, appreciate you opening this PR! Please give me a few days to find time to review & try this out, and we can try to merge ASAP!

@pdeligia
Copy link
Member

By the way, just enabled the CI on this PR. Seems there are some build issues, if you are able to iterate when you have time, we can retry run it.

@pdeligia
Copy link
Member

Also just in case it helps, this is last year's PR for upgrading to .NET 7, it should be pretty identical: #439

@WeihanLi
Copy link
Author

WeihanLi commented Dec 1, 2023

Should we drop the netcoreapp3.1 target since it's out of support now?

@pdeligia
Copy link
Member

pdeligia commented Dec 1, 2023

Should we drop the netcoreapp3.1 target since it's out of support now?

I would leave this target in for now, as AFAIK there are a few internal teams that still use it even if it's passed support as you say, can remove it at a later point.

@WeihanLi
Copy link
Author

WeihanLi commented Dec 2, 2023

@pdeligia could you please help on the failed tests when you have a time, no idea why it failed 😭

@pdeligia
Copy link
Member

pdeligia commented Dec 6, 2023

@pdeligia could you please help on the failed tests when you have a time, no idea why it failed 😭

I will try to review this and let you know, but just a heads up that it is now unlikely before end of the year (due to really busy schedule this month wrapping up high priority items before the holiday season, and also freezing any code changes for this year). We can try to merge this in Jan. Thanks a lot for your contribution!

@WeihanLi
Copy link
Author

WeihanLi commented Dec 6, 2023

Thanks very much

@pdeligia
Copy link
Member

pdeligia commented Mar 4, 2024

@WeihanLi I ended up upgrading coyote to .NET 8 as part of PR #497 (I had to do some tweaks on your PR which was much easier to work on a fresh branch that I had write access to). For this reason I am closing your PR, thanks a lot for your effort!

@pdeligia pdeligia closed this Mar 4, 2024
@WeihanLi WeihanLi deleted the net8-support branch June 22, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants