-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for std::span for winrt::array_view and winrt::com_array #1343
Support for std::span for winrt::array_view and winrt::com_array #1343
Conversation
Hopefully @DefaultRyan can spare a few minutes to look this over. He probably has the best handle on the standard library best practices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think the lifetime here is bonkers, but admittedly not any worse than the C++ standard library.
Sorry I'm a little late to the party. Do these new methods affect vtable layout at all? In other words, does span support need an ODR pragma to prevent mismatches? |
|
It's pure conversion methods; no change to the layout or functionality of |
This fixes #1289 per "option C" by completing what #1331 started.
@JaiganeshKumaran thank you for the initial start - see if this meets your needs, please.