Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell setup script fails in Windows PowerShell #624

Closed
waldekmastykarz opened this issue Mar 28, 2024 · 3 comments · Fixed by #626
Closed

PowerShell setup script fails in Windows PowerShell #624

waldekmastykarz opened this issue Mar 28, 2024 · 3 comments · Fixed by #626
Assignees
Labels
bug Something isn't working work in progress

Comments

@waldekmastykarz
Copy link
Collaborator

When you try to run the PowerShell setup script in Windows PowerShell it fails with Unsupported OS . Aborting. This is caused by Windows PowerShell not supporting $PSVersionTable.OS which we use to detect the OS. We need to either update the setup script to use an alternative way of detecting the OS or show a clear error message that Windows PowerShell is not supported and you should use Microsoft PowerShell instead. If we can't support Windows PowerShell, we should also include it in our docs.

@waldekmastykarz waldekmastykarz added the bug Something isn't working label Mar 28, 2024
@rutgersmit
Copy link

Stumbled upon this error this morning, thought it was because I was running it on a virtualised Windows 11 on a MacBook Air (Parallels). OS identifies itself as an ARM version. Tried this approach due to #609

Accidentally made a pr on the original repo, wanted to merge it into my own main first.

@rutgersmit
Copy link

Was working on a better pr and then saw you did exactly the same :)
I lowercased the OSDescription because you never know right?

Thanks for the fix!

@waldekmastykarz
Copy link
Collaborator Author

Was working on a better pr and then saw you did exactly the same :) I lowercased the OSDescription because you never know right?

Thanks for the fix!

Sorry I went over your PR: we needed the fix sooner for an experiment that we're running and I didn't want to push you on a our timeline. Once again, thank you for working with us, we appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants