Distributed tracing updates #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project was using a fork of
durabletask-protobufas a submodule and had diverged from the main branch. This PR aligns with the durabletask-protobuf main branch, which includes some changes to the distributed tracing protobuf contract. This misalignment was pointed out in #31.One notable change was the change to TraceContext, which previously defined
traceIDandspanIDas distinct values. However, the latestdurabletask-protobufreduced these to justtraceParentto be closer to the HTTP protocol. To make this non-breaking, I simply renamedtraceIDtotraceParentand deprecated thespanIDvalue without removing it. I also added some code that should try to handle this transition gracefully. This should hopefully allow any orchestrations created with the old schema to continue working with the new schema.We don't yet have any external SDKs that are taking advantage of the distributed tracing feature, so this is not expected to break any existing SDKs.
Lastly, this PR also happens to contain a new test,
Test_RecreateCompletedOrchestration. However, it's currently skipped as it requires additional feature work (probably could have gone into a separate PR but I'm being a bit lazy).