Skip to content

Commit

Permalink
Merge branch 'master' into users/scomea/empty-no-options
Browse files Browse the repository at this point in the history
  • Loading branch information
scomea authored Jan 4, 2024
2 parents 34f863b + 8023f7e commit c37dcf9
Show file tree
Hide file tree
Showing 128 changed files with 1,542 additions and 410 deletions.
5 changes: 4 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,7 @@ build/ @janechu @nicholasrice @chrisdholt @awentzel @EisenbergEffect

# Web components
/packages/web-components/fast-element/ @EisenbergEffect @chrisdholt @janechu @nicholasrice
/packages/web-components/fast-foundation/ @EisenbergEffect @chrisdholt @nicholasrice
/packages/web-components/fast-foundation/ @EisenbergEffect @chrisdholt @bheston @scomea @radium-v @kingoftac

# the change directory has no owners
/change/
2 changes: 1 addition & 1 deletion .github/workflows/cd-deploy-www-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
uses: actions/checkout@master

- name: Install Lerna
run: yarn global add lerna
run: yarn global add lerna@5.5.2

- name: Install package dependencies / prepare workspaces
run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cd-deploy-www-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
uses: actions/checkout@master

- name: Install Lerna
run: yarn global add lerna
run: yarn global add lerna@5.5.2

- name: Install package dependencies / prepare workspaces
run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cd-release-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
token: ${{ secrets.GH_TOKEN }}

- name: Add or Update packages
run: sudo yarn global add lerna
run: sudo yarn global add lerna@5.5.2

- name: Set Git User
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testing/ci-daily-local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
sudo apt-get update
sudo apt-get install yarn
sudo yarn global upgrade typescript
sudo yarn global add lerna
sudo yarn global add lerna@5.5.2
- name: Install package dependencies / prepare workspaces
run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ npm install -g yarn
The second tool you'll need is Lerna, which can be installed with this command:

```bash
yarn global add lerna
yarn global add lerna@5.5.2
```

:::important
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "prerelease",
"comment": "picker zero items",
"comment": "fix: allow tabs `setTabs` method to be extended",
"packageName": "@microsoft/fast-foundation",
"email": "stephcomeau@msn.com",
"email": "quic_scomeau@qualcomm.com",
"dependentChangeType": "prerelease"
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion examples/todo-app/src/todo-app.template.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { html, repeat } from "@microsoft/fast-element";
import { twoWay } from "@microsoft/fast-element/binding/two-way";
import { twoWay } from "@microsoft/fast-element/binding/two-way.js";
import type { TodoApp } from "./todo-app.js";
import type { Todo } from "./todo-list.js";
import "./todo-form.js";
Expand Down
6 changes: 2 additions & 4 deletions examples/todo-app/src/todo-form.template.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { html } from "@microsoft/fast-element";
import { twoWay } from "@microsoft/fast-element/binding/two-way";
import { twoWay } from "@microsoft/fast-element/binding/two-way.js";
import type { TodoForm } from "./todo-form.js";

export const template = html<TodoForm>`
<form @submit=${x => x.submitTodo()}>
<input type="text" :value=${twoWay(x => x.description, "input")} />
<button type="submit" ?disabled=${x => !x.description}>
Add Todo
</button>
<button type="submit" ?disabled=${x => !x.description}>Add Todo</button>
</form>
`;
4 changes: 2 additions & 2 deletions examples/todo-app/src/todo-list.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Observable, observable, volatile } from "@microsoft/fast-element";
import { Context } from "@microsoft/fast-element/context";
import { reactive } from "@microsoft/fast-element/state";
import { Context } from "@microsoft/fast-element/context.js";
import { reactive } from "@microsoft/fast-element/state.js";

export type Todo = { description: string; done: boolean };
export type TodoListFilter = "all" | "active" | "completed";
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/fast-benchmarks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"help": "node ./scripts/index.js --help"
},
"dependencies": {
"@microsoft/fast-element": "2.0.0-beta.24",
"@microsoft/fast-element": "2.0.0-beta.26",
"tachometer": "^0.7.0"
},
"devDependencies": {
Expand Down
52 changes: 52 additions & 0 deletions packages/utilities/fast-react-wrapper/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,58 @@
{
"name": "@microsoft/fast-react-wrapper",
"entries": [
{
"date": "Fri, 18 Aug 2023 00:04:39 GMT",
"tag": "@microsoft/fast-react-wrapper_v1.0.0-alpha.27",
"version": "1.0.0-alpha.27",
"comments": {
"none": [
{
"author": "chhol@microsoft.com",
"package": "@microsoft/fast-react-wrapper",
"commit": "2dab94c0eda05bee7c4b497e68951d79d6fcbe46",
"comment": "fix test to use fast-element package export with extension"
}
],
"prerelease": [
{
"author": "beachball",
"package": "@microsoft/fast-react-wrapper",
"comment": "Bump @microsoft/fast-element to v2.0.0-beta.26",
"commit": "2dab94c0eda05bee7c4b497e68951d79d6fcbe46"
}
]
}
},
{
"date": "Sat, 12 Aug 2023 00:26:35 GMT",
"tag": "@microsoft/fast-react-wrapper_v1.0.0-alpha.26",
"version": "1.0.0-alpha.26",
"comments": {
"none": [
{
"author": "chhol@microsoft.com",
"package": "@microsoft/fast-react-wrapper",
"commit": "fc98190c6bfb9fabe0988e89daca1c0f64f6e7c8",
"comment": "adds missing types as a dev dependency"
}
],
"prerelease": [
{
"author": "chhol@microsoft.com",
"package": "@microsoft/fast-react-wrapper",
"commit": "0f8fc2505445be626e55e1e1b28956c2ff3a722e",
"comment": "add displayName to react wrapper"
},
{
"author": "beachball",
"package": "@microsoft/fast-react-wrapper",
"comment": "Bump @microsoft/fast-element to v2.0.0-beta.25",
"commit": "2297004e14386b5a689ba96361f8d8eebee69cd8"
}
]
}
},
{
"date": "Fri, 16 Jun 2023 18:17:13 GMT",
"tag": "@microsoft/fast-react-wrapper_v1.0.0-alpha.25",
Expand Down
19 changes: 18 additions & 1 deletion packages/utilities/fast-react-wrapper/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,26 @@
# Change Log - @microsoft/fast-react-wrapper

This log was last generated on Fri, 16 Jun 2023 18:17:13 GMT and should not be manually modified.
This log was last generated on Fri, 18 Aug 2023 00:04:39 GMT and should not be manually modified.

<!-- Start content -->

## 1.0.0-alpha.27

Fri, 18 Aug 2023 00:04:39 GMT

### Changes

- Bump @microsoft/fast-element to v2.0.0-beta.26

## 1.0.0-alpha.26

Sat, 12 Aug 2023 00:26:35 GMT

### Changes

- add displayName to react wrapper (chhol@microsoft.com)
- Bump @microsoft/fast-element to v2.0.0-beta.25

## 1.0.0-alpha.25

Fri, 16 Jun 2023 18:17:13 GMT
Expand Down
4 changes: 2 additions & 2 deletions packages/utilities/fast-react-wrapper/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@microsoft/fast-react-wrapper",
"description": "A utility for wrapping web components for use in React.",
"sideEffects": false,
"version": "1.0.0-alpha.25",
"version": "1.0.0-alpha.27",
"author": {
"name": "Microsoft",
"url": "https://discord.gg/FcSNfg4"
Expand Down Expand Up @@ -83,7 +83,7 @@
"webpack-cli": "^4.9.2"
},
"dependencies": {
"@microsoft/fast-element": "^2.0.0-beta.24"
"@microsoft/fast-element": "^2.0.0-beta.26"
},
"peerDependencies": {
"react": ">=16.9.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/fast-react-wrapper/src/index.spec.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { attr, customElement, DOM, FASTElement, html, nullableNumberConverter, observable, Updates } from '@microsoft/fast-element';
import React from "react";
import ReactDOM from "react-dom";
import { uniqueElementName } from '@microsoft/fast-element/testing';
import { uniqueElementName } from '@microsoft/fast-element/testing.js';
import { expect } from "chai";
import { reactWrapper } from './index.js';

Expand Down
15 changes: 15 additions & 0 deletions packages/utilities/fast-web-utilities/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
{
"name": "@microsoft/fast-web-utilities",
"entries": [
{
"date": "Wed, 20 Dec 2023 19:03:47 GMT",
"tag": "@microsoft/fast-web-utilities_v6.0.0",
"version": "6.0.0",
"comments": {
"none": [
{
"author": "863023+radium-v@users.noreply.github.com",
"package": "@microsoft/fast-web-utilities",
"commit": "fd65254531ac3a593b32528d81b44ebf82c8e4ab",
"comment": "fix RtlScrollConverter test"
}
]
}
},
{
"date": "Fri, 16 Jun 2023 18:17:13 GMT",
"tag": "@microsoft/fast-web-utilities_v6.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/utilities/fast-web-utilities/karma.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const commonChromeFlags = [
"--disable-extensions",
"--disable-infobars",
"--disable-translate",
"--force-device-scale-factor=1",
];

module.exports = function (config: any) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,14 @@ describe("RtlScrollConverter", (): void => {
);
});

it("invertedGetRtlScrollConverter returns correct value", () => {
it("invertedGetRtlScrollConverter returns a value <= 0", () => {
const testElement: HTMLDivElement = getDummyDiv();
document.body.appendChild(testElement);
testElement.scrollLeft = 1;

expect(RtlScrollConverter["invertedGetRtlScrollConverter"](testElement)).to.equal(
-1
);
expect(
RtlScrollConverter["invertedGetRtlScrollConverter"](testElement)
).to.be.lessThanOrEqual(0);
});

it("reverseGetRtlScrollConverter returns correct value", () => {
Expand Down
42 changes: 42 additions & 0 deletions packages/web-components/fast-element/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,48 @@
{
"name": "@microsoft/fast-element",
"entries": [
{
"date": "Fri, 18 Aug 2023 00:04:40 GMT",
"tag": "@microsoft/fast-element_v2.0.0-beta.26",
"version": "2.0.0-beta.26",
"comments": {
"prerelease": [
{
"author": "chhol@microsoft.com",
"package": "@microsoft/fast-element",
"commit": "2dab94c0eda05bee7c4b497e68951d79d6fcbe46",
"comment": "BREAKING: update fast-element export paths to include extensions"
},
{
"author": "chhol@microsoft.com",
"package": "@microsoft/fast-element",
"commit": "8a23a94530ec7e6fb269c149bd70ca97e662dbf4",
"comment": "update fast-element exports to be explicit"
}
]
}
},
{
"date": "Sat, 12 Aug 2023 00:26:36 GMT",
"tag": "@microsoft/fast-element_v2.0.0-beta.25",
"version": "2.0.0-beta.25",
"comments": {
"prerelease": [
{
"author": "nicholasrice@users.noreply.github.com",
"package": "@microsoft/fast-element",
"commit": "ff0b93a7fb4ca416629f51cc233078494aaf5f60",
"comment": "Prevent notification of array splices when operation does not mutate array values"
},
{
"author": "nicholasrice@users.noreply.github.com",
"package": "@microsoft/fast-element",
"commit": "9f6451f7e7c121d76e2ead6f50f77c312a0157f7",
"comment": "Adds volatile binding support for JavaScript optional chaining syntax"
}
]
}
},
{
"date": "Fri, 16 Jun 2023 18:17:12 GMT",
"tag": "@microsoft/fast-element_v2.0.0-beta.24",
Expand Down
Loading

0 comments on commit c37dcf9

Please sign in to comment.