Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add passive link/URL handling mode to fast-router #6605

Open
hajo-travanto opened this issue Jan 14, 2023 · 0 comments
Open

feat: add passive link/URL handling mode to fast-router #6605

hajo-travanto opened this issue Jan 14, 2023 · 0 comments
Labels
area:fast-router Pertains to fast-router feature A new feature status:under-consideration Issue is being reviewed by the team.

Comments

@hajo-travanto
Copy link

🙋 Feature Request

Currently the fast-router is catching the URL changes from outside the webcomponent itself, too

🤔 Expected Behavior

The router should have an option to enable/disable this behavior

😯 Current Behavior

It executes the internal process for it, including the fallback handling

💁 Possible Solution

Either a way to turn on/off the routing functionality on demand or restrict it to webcomponent internal links and URL switches

🔦 Context

The webcomponent is embedded in multiple websites as an extra service, but in the current way it kinda "damages" the websites if the routing is not containing a workaround to prevent this behavior

💻 Examples

E.g. if a link with a relative path in the URL is clicked like "/abc1" which might not be intended to be handled by it, the fast-router still executes itself and other routers or the default browser have no chance to "jump in" and apply the intended routing

@hajo-travanto hajo-travanto added the status:triage New Issue - needs triage label Jan 14, 2023
@janechu janechu added feature A new feature status:under-consideration Issue is being reviewed by the team. area:fast-router Pertains to fast-router and removed status:triage New Issue - needs triage labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-router Pertains to fast-router feature A new feature status:under-consideration Issue is being reviewed by the team.
Projects
None yet
Development

No branches or pull requests

2 participants