From 5d5a9a441071cd5b96377ae5de88703f83056e5b Mon Sep 17 00:00:00 2001 From: Juraj Kapsiar Date: Fri, 24 Jan 2020 15:26:35 +0100 Subject: [PATCH 1/3] port FocusTrapZone leak fix from Fabric --- packages/react-bindings/src/FocusZone/FocusTrapZone.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-bindings/src/FocusZone/FocusTrapZone.tsx b/packages/react-bindings/src/FocusZone/FocusTrapZone.tsx index 285aa12ac0..0d098fcbfb 100644 --- a/packages/react-bindings/src/FocusZone/FocusTrapZone.tsx +++ b/packages/react-bindings/src/FocusZone/FocusTrapZone.tsx @@ -124,6 +124,10 @@ export default class FocusTrapZone extends React.Component Date: Fri, 24 Jan 2020 15:29:18 +0100 Subject: [PATCH 2/3] changelog --- CHANGELOG.md | 1 + packages/react-bindings/src/FocusZone/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 60c8bbf30e..0415a4778c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Fix event listener leak in `FocusZone` @miroslavstastny ([#2227](https://github.com/microsoft/fluent-ui-react/pull/2227)) - Fix styleParam to always be required in the styles functions @layershifter, @mnajdova ([#2235](https://github.com/microsoft/fluent-ui-react/pull/2235)) - Check input and button refs exist before focus in `Dropdown` @silviuavram ([#2248](https://github.com/microsoft/fluent-ui-react/pull/2248)) +- Fix element reference memory leaks @jurokapsiar ([https://github.com/microsoft/fluent-ui-react/pull/2270](2270)) ### Features - Allow `useRef` hook used for storing debugging data to be defined in any order with other hooks in functional components @layershifter, @mnajdova ([#2236](https://github.com/microsoft/fluent-ui-react/pull/2236)) diff --git a/packages/react-bindings/src/FocusZone/CHANGELOG.md b/packages/react-bindings/src/FocusZone/CHANGELOG.md index 6107e87e91..883870119f 100644 --- a/packages/react-bindings/src/FocusZone/CHANGELOG.md +++ b/packages/react-bindings/src/FocusZone/CHANGELOG.md @@ -15,6 +15,7 @@ This is a list of changes made to this Stardust copy of FocusZone in comparison - `FocusZone` should respect elements with `contenteditable` attribute on Home/End key press @sophieH29 ([#1749](https://github.com/stardust-ui/react/pull/1749)) - Fix bidirectional `FocusZone` to land focus correctly on DOWN key press after series of UP arrow keys @sophieH29 ([#1794](https://github.com/stardust-ui/react/pull/1794)) - Use always `getDocument` to correctly define current document object @sophieH29 ([#1820](https://github.com/stardust-ui/react/pull/1820)) +- Fix element reference memory leaks - Fabric PR 11618 @jurokapsiar ([https://github.com/microsoft/fluent-ui-react/pull/2270](2270)) ### Features - Add embed mode for FocusZone and new Chat behavior ([#233](https://github.com/stardust-ui/react/pull/233)) From cfd56e5c30c7051117bcb0f7169786a0afb5e7d6 Mon Sep 17 00:00:00 2001 From: Juraj Kapsiar Date: Fri, 24 Jan 2020 15:31:30 +0100 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 2 +- packages/react-bindings/src/FocusZone/CHANGELOG.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0415a4778c..7607187389 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,7 +27,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Fix event listener leak in `FocusZone` @miroslavstastny ([#2227](https://github.com/microsoft/fluent-ui-react/pull/2227)) - Fix styleParam to always be required in the styles functions @layershifter, @mnajdova ([#2235](https://github.com/microsoft/fluent-ui-react/pull/2235)) - Check input and button refs exist before focus in `Dropdown` @silviuavram ([#2248](https://github.com/microsoft/fluent-ui-react/pull/2248)) -- Fix element reference memory leaks @jurokapsiar ([https://github.com/microsoft/fluent-ui-react/pull/2270](2270)) +- Fix element reference memory leaks @jurokapsiar ([#2270](https://github.com/microsoft/fluent-ui-react/pull/2270)) ### Features - Allow `useRef` hook used for storing debugging data to be defined in any order with other hooks in functional components @layershifter, @mnajdova ([#2236](https://github.com/microsoft/fluent-ui-react/pull/2236)) diff --git a/packages/react-bindings/src/FocusZone/CHANGELOG.md b/packages/react-bindings/src/FocusZone/CHANGELOG.md index 883870119f..f3601a59d0 100644 --- a/packages/react-bindings/src/FocusZone/CHANGELOG.md +++ b/packages/react-bindings/src/FocusZone/CHANGELOG.md @@ -15,7 +15,7 @@ This is a list of changes made to this Stardust copy of FocusZone in comparison - `FocusZone` should respect elements with `contenteditable` attribute on Home/End key press @sophieH29 ([#1749](https://github.com/stardust-ui/react/pull/1749)) - Fix bidirectional `FocusZone` to land focus correctly on DOWN key press after series of UP arrow keys @sophieH29 ([#1794](https://github.com/stardust-ui/react/pull/1794)) - Use always `getDocument` to correctly define current document object @sophieH29 ([#1820](https://github.com/stardust-ui/react/pull/1820)) -- Fix element reference memory leaks - Fabric PR 11618 @jurokapsiar ([https://github.com/microsoft/fluent-ui-react/pull/2270](2270)) +- Fix element reference memory leaks - Fabric PR 11618 @jurokapsiar ([#2270](https://github.com/microsoft/fluent-ui-react/pull/2270)) ### Features - Add embed mode for FocusZone and new Chat behavior ([#233](https://github.com/stardust-ui/react/pull/233))