-
Notifications
You must be signed in to change notification settings - Fork 458
[DataGrid] Asynchronous IQueryable based loading and error handling UI feedback #4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Asynchronous IQueryable based loading and error handling UI feedback #4177
Conversation
|
The We cannot just alter the test to make it pass with the new code. That would mean we introduce a breaking change (albeit a small one) Please review the PR and make the necessary changes so all tests pass unaltered. Thanks |
|
@vnbaaij I'll check the failing unit test and apply required fixes. Thanks |
|
@miguelhasse now there are 3 failed Unit Tests...
Use this code in the IssueTester to verify the result with current version: |
|
@vnbaaij Could this new feature be added to v5? |
* Implement #4036 * Implement #4070 * Implement #4112 * Implement #4116 * Add extra test. Brings back code coverage to 100% for Row and Cell * Implement #4172 * Implement #4177 * - Remove NoTabbing parameter (not being used) - Exclude ErrorContent from code coverage - Add (partial) ErrorContentTest, add IsFixed test, update tests * Implement #4178 Related Work Items: #41 * Add CustomIcon and IconsExtensions + tests --------- Co-authored-by: Denis Voituron <dvoituron@outlook.com>



Pull Request
📖 Description
This feature introduces two visual enhancements to the DataGrid component while asynchronously loading items from an IQueryable data source:
👩💻 Reviewer Notes
A working sample of the 'Loading' state flag feature can be seen in the following samples:
These same samples can be used to see a working sample for the error handling feature by forcing data source connection errors.
✅ Checklist
General
Component-specific