From 2338c30df092ac05df393631bb8e59bcd9fec7b0 Mon Sep 17 00:00:00 2001 From: Makoto Morimoto Date: Wed, 24 Mar 2021 11:27:06 -0700 Subject: [PATCH 1/8] Autofill: Inherit font-family to prevent defaulting to Arial (#17507) * Autofill: Inherit font-family to prevent defaulting to Arial. * Change files * Updating snapshots. --- ...-examples-2151236c-fd6b-4527-8944-7a11fce9088e.json | 7 +++++++ ...periments-99ea7ebe-27e3-46a8-8413-3cb05e0b94ce.json | 7 +++++++ ...tui-react-f7171097-ecc1-47fe-868e-08023aba68f3.json | 7 +++++++ .../Announced.SearchResults.Example.tsx.shot | 5 +++++ .../__snapshots__/ComboBox.Basic.Example.tsx.shot | 10 ++++++++++ .../__snapshots__/ComboBox.Controlled.Example.tsx.shot | 5 +++++ .../ComboBox.ControlledMulti.Example.tsx.shot | 5 +++++ .../ComboBox.CustomStyled.Example.tsx.shot | 10 ++++++++++ .../ComboBox.ErrorHandling.Example.tsx.shot | 10 ++++++++++ .../__snapshots__/ComboBox.Toggles.Example.tsx.shot | 5 +++++ .../ComboBox.Virtualized.Example.tsx.shot | 5 +++++ .../ExtendedPeoplePicker.Basic.Example.tsx.shot | 10 ++++++++++ .../ExtendedPeoplePicker.Controlled.Example.tsx.shot | 10 ++++++++++ .../PeoplePicker.Compact.Example.tsx.shot | 5 +++++ .../PeoplePicker.Controlled.Example.tsx.shot | 5 +++++ .../PeoplePicker.LimitedSearch.Example.tsx.shot | 5 +++++ .../__snapshots__/PeoplePicker.List.Example.tsx.shot | 5 +++++ .../__snapshots__/PeoplePicker.Normal.Example.tsx.shot | 5 +++++ .../PeoplePicker.PreselectedItems.Example.tsx.shot | 5 +++++ .../PeoplePicker.ProcessSelection.Example.tsx.shot | 5 +++++ .../__snapshots__/TagPicker.Basic.Example.tsx.shot | 10 ++++++++++ .../Pagination/__snapshots__/Pagination.test.tsx.snap | 5 +++++ .../__snapshots__/UnifiedPeoplePicker.test.tsx.snap | 10 ++++++++++ .../__snapshots__/UnifiedPicker.test.tsx.snap | 10 ++++++++++ packages/react/src/components/Autofill/Autofill.tsx | 2 ++ .../ComboBox/__snapshots__/ComboBox.test.tsx.snap | 8 ++++++++ .../__snapshots__/BaseExtendedPicker.test.tsx.snap | 10 ++++++++++ .../__snapshots__/PeoplePicker.test.tsx.snap | 10 ++++++++++ .../TagPicker/__snapshots__/TagPicker.test.tsx.snap | 10 ++++++++++ .../pickers/__snapshots__/BasePicker.test.tsx.snap | 10 ++++++++++ 30 files changed, 216 insertions(+) create mode 100644 change/@fluentui-react-examples-2151236c-fd6b-4527-8944-7a11fce9088e.json create mode 100644 change/@fluentui-react-experiments-99ea7ebe-27e3-46a8-8413-3cb05e0b94ce.json create mode 100644 change/@fluentui-react-f7171097-ecc1-47fe-868e-08023aba68f3.json diff --git a/change/@fluentui-react-examples-2151236c-fd6b-4527-8944-7a11fce9088e.json b/change/@fluentui-react-examples-2151236c-fd6b-4527-8944-7a11fce9088e.json new file mode 100644 index 00000000000000..a528af0851f420 --- /dev/null +++ b/change/@fluentui-react-examples-2151236c-fd6b-4527-8944-7a11fce9088e.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Autofill: Inherit font-family to prevent defaulting to Arial.", + "packageName": "@fluentui/react-examples", + "email": "Humberto.Morimoto@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/change/@fluentui-react-experiments-99ea7ebe-27e3-46a8-8413-3cb05e0b94ce.json b/change/@fluentui-react-experiments-99ea7ebe-27e3-46a8-8413-3cb05e0b94ce.json new file mode 100644 index 00000000000000..68a3882169aa3d --- /dev/null +++ b/change/@fluentui-react-experiments-99ea7ebe-27e3-46a8-8413-3cb05e0b94ce.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Updating snapshots.", + "packageName": "@fluentui/react-experiments", + "email": "Humberto.Morimoto@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/change/@fluentui-react-f7171097-ecc1-47fe-868e-08023aba68f3.json b/change/@fluentui-react-f7171097-ecc1-47fe-868e-08023aba68f3.json new file mode 100644 index 00000000000000..42ca8cd743f552 --- /dev/null +++ b/change/@fluentui-react-f7171097-ecc1-47fe-868e-08023aba68f3.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Autofill: Inherit font-family to prevent defaulting to Arial.", + "packageName": "@fluentui/react", + "email": "Humberto.Morimoto@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/packages/react-examples/src/react/__snapshots__/Announced.SearchResults.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/Announced.SearchResults.Example.tsx.shot index 5d39a9d0c0c0bb..aa851cd479b6ed 100644 --- a/packages/react-examples/src/react/__snapshots__/Announced.SearchResults.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/Announced.SearchResults.Example.tsx.shot @@ -132,6 +132,11 @@ exports[`Component Examples renders Announced.SearchResults.Example.tsx correctl onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.Basic.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.Basic.Example.tsx.shot index 42ba67fa73ea71..83d50f817a95fb 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.Basic.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.Basic.Example.tsx.shot @@ -238,6 +238,11 @@ exports[`Component Examples renders ComboBox.Basic.Example.tsx correctly 1`] = ` onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Option C" /> @@ -797,6 +802,11 @@ exports[`Component Examples renders ComboBox.Basic.Example.tsx correctly 1`] = ` onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Option C" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.Controlled.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.Controlled.Example.tsx.shot index 031ea15c2a1cad..972e3214fcfe6a 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.Controlled.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.Controlled.Example.tsx.shot @@ -258,6 +258,11 @@ exports[`Component Examples renders ComboBox.Controlled.Example.tsx correctly 1` onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Option C" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.ControlledMulti.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.ControlledMulti.Example.tsx.shot index 9d41d1e7cbb7a1..9e556bc270c96c 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.ControlledMulti.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.ControlledMulti.Example.tsx.shot @@ -279,6 +279,11 @@ exports[`Component Examples renders ComboBox.ControlledMulti.Example.tsx correct onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Option C, Option D" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.CustomStyled.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.CustomStyled.Example.tsx.shot index 73b182bc2ed112..9e5ed9fda40079 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.CustomStyled.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.CustomStyled.Example.tsx.shot @@ -258,6 +258,11 @@ exports[`Component Examples renders ComboBox.CustomStyled.Example.tsx correctly onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Calibri" /> @@ -659,6 +664,11 @@ exports[`Component Examples renders ComboBox.CustomStyled.Example.tsx correctly onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Calibri" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.ErrorHandling.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.ErrorHandling.Example.tsx.shot index 1a21287dc51b2e..e0f06b7725d90d 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.ErrorHandling.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.ErrorHandling.Example.tsx.shot @@ -194,6 +194,11 @@ exports[`Component Examples renders ComboBox.ErrorHandling.Example.tsx correctly onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Option B" /> @@ -605,6 +610,11 @@ exports[`Component Examples renders ComboBox.ErrorHandling.Example.tsx correctly onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.Toggles.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.Toggles.Example.tsx.shot index d87d7fa0f1f644..7b5f68be92a2d6 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.Toggles.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.Toggles.Example.tsx.shot @@ -258,6 +258,11 @@ exports[`Component Examples renders ComboBox.Toggles.Example.tsx correctly 1`] = onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/ComboBox.Virtualized.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ComboBox.Virtualized.Example.tsx.shot index 4a587bf1cd7b7f..f98657461b0148 100644 --- a/packages/react-examples/src/react/__snapshots__/ComboBox.Virtualized.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ComboBox.Virtualized.Example.tsx.shot @@ -237,6 +237,11 @@ exports[`Component Examples renders ComboBox.Virtualized.Example.tsx correctly 1 onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="Option 547" /> diff --git a/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Basic.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Basic.Example.tsx.shot index 04c079ee636608..c10f44f02c3b8c 100644 --- a/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Basic.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Basic.Example.tsx.shot @@ -73,6 +73,11 @@ exports[`Component Examples renders ExtendedPeoplePicker.Basic.Example.tsx corre onKeyDown={[Function]} onPaste={[Function]} role="combobox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -291,6 +296,11 @@ exports[`Component Examples renders ExtendedPeoplePicker.Basic.Example.tsx corre onKeyDown={[Function]} onPaste={[Function]} role="combobox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Controlled.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Controlled.Example.tsx.shot index f7ff7ab64b59ad..f061de3e5f8388 100644 --- a/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Controlled.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/ExtendedPeoplePicker.Controlled.Example.tsx.shot @@ -73,6 +73,11 @@ exports[`Component Examples renders ExtendedPeoplePicker.Controlled.Example.tsx onKeyDown={[Function]} onPaste={[Function]} role="combobox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -291,6 +296,11 @@ exports[`Component Examples renders ExtendedPeoplePicker.Controlled.Example.tsx onKeyDown={[Function]} onPaste={[Function]} role="combobox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.Compact.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.Compact.Example.tsx.shot index c2093e3d396258..e14cde9dbdc856 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.Compact.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.Compact.Example.tsx.shot @@ -96,6 +96,11 @@ exports[`Component Examples renders PeoplePicker.Compact.Example.tsx correctly 1 onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.Controlled.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.Controlled.Example.tsx.shot index 1793e02e504e11..9308adb0987943 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.Controlled.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.Controlled.Example.tsx.shot @@ -96,6 +96,11 @@ exports[`Component Examples renders PeoplePicker.Controlled.Example.tsx correctl onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.LimitedSearch.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.LimitedSearch.Example.tsx.shot index 888868a2f6337a..92e2af22d3dca5 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.LimitedSearch.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.LimitedSearch.Example.tsx.shot @@ -96,6 +96,11 @@ exports[`Component Examples renders PeoplePicker.LimitedSearch.Example.tsx corre onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.List.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.List.Example.tsx.shot index 30a91e5c8f7374..7a50c2e27666fe 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.List.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.List.Example.tsx.shot @@ -72,6 +72,11 @@ exports[`Component Examples renders PeoplePicker.List.Example.tsx correctly 1`] onInput={[Function]} onKeyDown={[Function]} role="textbox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.Normal.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.Normal.Example.tsx.shot index 3fe06b4884ad1d..0c632ef0ff37b1 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.Normal.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.Normal.Example.tsx.shot @@ -96,6 +96,11 @@ exports[`Component Examples renders PeoplePicker.Normal.Example.tsx correctly 1` onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.PreselectedItems.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.PreselectedItems.Example.tsx.shot index e2899246da13e1..41409c8f4f38f4 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.PreselectedItems.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.PreselectedItems.Example.tsx.shot @@ -1447,6 +1447,11 @@ exports[`Component Examples renders PeoplePicker.PreselectedItems.Example.tsx co onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/PeoplePicker.ProcessSelection.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/PeoplePicker.ProcessSelection.Example.tsx.shot index a4baa49d5a196e..4cd9c22f1727eb 100644 --- a/packages/react-examples/src/react/__snapshots__/PeoplePicker.ProcessSelection.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/PeoplePicker.ProcessSelection.Example.tsx.shot @@ -96,6 +96,11 @@ exports[`Component Examples renders PeoplePicker.ProcessSelection.Example.tsx co onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-examples/src/react/__snapshots__/TagPicker.Basic.Example.tsx.shot b/packages/react-examples/src/react/__snapshots__/TagPicker.Basic.Example.tsx.shot index d0002235c96f29..c5d474abd9bfef 100644 --- a/packages/react-examples/src/react/__snapshots__/TagPicker.Basic.Example.tsx.shot +++ b/packages/react-examples/src/react/__snapshots__/TagPicker.Basic.Example.tsx.shot @@ -235,6 +235,11 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] = onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -337,6 +342,11 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] = onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap b/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap index cffa7d645c6d64..651d7e99eaeb1a 100644 --- a/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap +++ b/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap @@ -1561,6 +1561,11 @@ exports[`Pagination render comboBox Pagination correctly 1`] = ` onTouchStart={[Function]} role="combobox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } type="text" value="1" /> diff --git a/packages/react-experiments/src/components/UnifiedPicker/UnifiedPeoplePicker/__snapshots__/UnifiedPeoplePicker.test.tsx.snap b/packages/react-experiments/src/components/UnifiedPicker/UnifiedPeoplePicker/__snapshots__/UnifiedPeoplePicker.test.tsx.snap index e385b9fbba534b..0182a3d7cbcc41 100644 --- a/packages/react-experiments/src/components/UnifiedPicker/UnifiedPeoplePicker/__snapshots__/UnifiedPeoplePicker.test.tsx.snap +++ b/packages/react-experiments/src/components/UnifiedPicker/UnifiedPeoplePicker/__snapshots__/UnifiedPeoplePicker.test.tsx.snap @@ -112,6 +112,11 @@ exports[`UnifiedPeoplePicker renders correctly with no items 1`] = ` onInput={[Function]} onKeyDown={[Function]} onPaste={[Function]} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -879,6 +884,11 @@ exports[`UnifiedPeoplePicker renders correctly with selected and suggested items onInput={[Function]} onKeyDown={[Function]} onPaste={[Function]} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react-experiments/src/components/UnifiedPicker/__snapshots__/UnifiedPicker.test.tsx.snap b/packages/react-experiments/src/components/UnifiedPicker/__snapshots__/UnifiedPicker.test.tsx.snap index af25ab1563ea47..9e13a3d42d1b04 100644 --- a/packages/react-experiments/src/components/UnifiedPicker/__snapshots__/UnifiedPicker.test.tsx.snap +++ b/packages/react-experiments/src/components/UnifiedPicker/__snapshots__/UnifiedPicker.test.tsx.snap @@ -112,6 +112,11 @@ exports[`UnifiedPicker renders correctly with no items 1`] = ` onInput={[Function]} onKeyDown={[Function]} onPaste={[Function]} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -263,6 +268,11 @@ exports[`UnifiedPicker renders correctly with selected and suggested items 1`] = onInput={[Function]} onKeyDown={[Function]} onPaste={[Function]} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react/src/components/Autofill/Autofill.tsx b/packages/react/src/components/Autofill/Autofill.tsx index afc5a77f0f5892..4746f7c9e260a7 100644 --- a/packages/react/src/components/Autofill/Autofill.tsx +++ b/packages/react/src/components/Autofill/Autofill.tsx @@ -126,12 +126,14 @@ export class Autofill extends React.Component im public render(): JSX.Element { const nativeProps = getNativeProps>(this.props, inputProperties); + const style = { ...this.props.style, fontFamily: 'inherit' }; return ( @@ -554,6 +559,7 @@ exports[`ComboBox Renders correctly when open 1`] = ` id="ComboBox0-input" role="combobox" spellcheck="false" + style="font-family: inherit;" type="text" value="Option 2" /> @@ -1323,6 +1329,7 @@ exports[`ComboBox Renders correctly when opened in multi-select mode 1`] = ` placeholder="Option 2" role="combobox" spellcheck="false" + style="font-family: inherit;" type="text" value="" /> @@ -2218,6 +2225,7 @@ exports[`ComboBox renders with a Keytip correctly 1`] = ` id="ComboBox0-input" role="combobox" spellcheck="false" + style="font-family: inherit;" type="text" value="" /> diff --git a/packages/react/src/components/ExtendedPicker/__snapshots__/BaseExtendedPicker.test.tsx.snap b/packages/react/src/components/ExtendedPicker/__snapshots__/BaseExtendedPicker.test.tsx.snap index 8330aeb2f57ec3..08cc9c8155a0be 100644 --- a/packages/react/src/components/ExtendedPicker/__snapshots__/BaseExtendedPicker.test.tsx.snap +++ b/packages/react/src/components/ExtendedPicker/__snapshots__/BaseExtendedPicker.test.tsx.snap @@ -51,6 +51,11 @@ exports[`Pickers BasePicker renders BaseExtendedPicker correctly with no items 1 onKeyDown={[Function]} onPaste={[Function]} role="combobox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -121,6 +126,11 @@ exports[`Pickers BasePicker renders BaseExtendedPicker correctly with selected a onKeyDown={[Function]} onPaste={[Function]} role="combobox" + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react/src/components/pickers/PeoplePicker/__snapshots__/PeoplePicker.test.tsx.snap b/packages/react/src/components/pickers/PeoplePicker/__snapshots__/PeoplePicker.test.tsx.snap index e0eef2cb606f94..c027f8541cbe40 100644 --- a/packages/react/src/components/pickers/PeoplePicker/__snapshots__/PeoplePicker.test.tsx.snap +++ b/packages/react/src/components/pickers/PeoplePicker/__snapshots__/PeoplePicker.test.tsx.snap @@ -93,6 +93,11 @@ exports[`PeoplePicker renders correctly 1`] = ` onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -653,6 +658,11 @@ exports[`PeoplePicker renders correctly with preselected items 1`] = ` onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react/src/components/pickers/TagPicker/__snapshots__/TagPicker.test.tsx.snap b/packages/react/src/components/pickers/TagPicker/__snapshots__/TagPicker.test.tsx.snap index a327f868926f73..40f941affd1fb7 100644 --- a/packages/react/src/components/pickers/TagPicker/__snapshots__/TagPicker.test.tsx.snap +++ b/packages/react/src/components/pickers/TagPicker/__snapshots__/TagPicker.test.tsx.snap @@ -301,6 +301,11 @@ exports[`TagPicker renders correctly 1`] = ` onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -610,6 +615,11 @@ exports[`TagPicker renders picker with selected item correctly 1`] = ` onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> diff --git a/packages/react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap b/packages/react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap index a8c1698c2def31..f0a292256d3df6 100644 --- a/packages/react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap +++ b/packages/react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap @@ -55,6 +55,11 @@ exports[`BasePicker renders correctly 1`] = ` onKeyDown={[Function]} role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> @@ -120,6 +125,11 @@ exports[`BasePicker renders with inputProps supply classnames correctly 1`] = ` placeholder="Bitte einen Benutzer angeben..." role="textbox" spellCheck={false} + style={ + Object { + "fontFamily": "inherit", + } + } value="" /> From b8e8697d9f3ff285687b7cba27b9ac037a0cb727 Mon Sep 17 00:00:00 2001 From: Kham Udom <37851220+khamudom@users.noreply.github.com> Date: Wed, 24 Mar 2021 11:36:36 -0700 Subject: [PATCH 2/8] fix: removed SVGs and update fill style in accordion (#17527) * removed SVGs to use the default * Change files * set the fill color of the icon in style * using accentFillRestBehavior.var on fill --- ...-199e3bcd-b1b1-4ab4-aba7-c3c11a6d5d60.json | 7 + .../accordion-item/accordion-item.styles.ts | 6 + .../src/accordion/fixtures/base.html | 301 ------------------ 3 files changed, 13 insertions(+), 301 deletions(-) create mode 100644 change/@fluentui-web-components-199e3bcd-b1b1-4ab4-aba7-c3c11a6d5d60.json diff --git a/change/@fluentui-web-components-199e3bcd-b1b1-4ab4-aba7-c3c11a6d5d60.json b/change/@fluentui-web-components-199e3bcd-b1b1-4ab4-aba7-c3c11a6d5d60.json new file mode 100644 index 00000000000000..3e0fae1045833a --- /dev/null +++ b/change/@fluentui-web-components-199e3bcd-b1b1-4ab4-aba7-c3c11a6d5d60.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "removed SVGs to use the default", + "packageName": "@fluentui/web-components", + "email": "khamu@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/packages/web-components/src/accordion/accordion-item/accordion-item.styles.ts b/packages/web-components/src/accordion/accordion-item/accordion-item.styles.ts index ac6614490d17f4..30a82d8e2a4012 100644 --- a/packages/web-components/src/accordion/accordion-item/accordion-item.styles.ts +++ b/packages/web-components/src/accordion/accordion-item/accordion-item.styles.ts @@ -2,6 +2,7 @@ import { css } from '@microsoft/fast-element'; import { display, focusVisible, forcedColorsStylesheetBehavior } from '@microsoft/fast-foundation'; import { SystemColors } from '@microsoft/fast-web-utilities'; import { + accentFillRestBehavior, neutralDividerRestBehavior, neutralFocusBehavior, neutralForegroundActiveBehavior, @@ -85,6 +86,7 @@ export const AccordionItemStyles = css` grid-column: 4; z-index: 2; pointer-events: none; + fill: ${accentFillRestBehavior.var}; } slot[name="collapsed-icon"] { @@ -120,6 +122,7 @@ export const AccordionItemStyles = css` z-index: 2; } `.withBehaviors( + accentFillRestBehavior, neutralDividerRestBehavior, neutralForegroundActiveBehavior, neutralForegroundFocusBehavior, @@ -132,6 +135,9 @@ export const AccordionItemStyles = css` border-color: ${SystemColors.Highlight}; box-shadow: 0 0 0 calc((var(--focus-outline-width) - var(--outline-width)) * 1px) ${SystemColors.Highlight}; } + .icon { + fill: ${SystemColors.ButtonText}; + } `, ), ); diff --git a/packages/web-components/src/accordion/fixtures/base.html b/packages/web-components/src/accordion/fixtures/base.html index 3941b944a44f70..cdb17147feba8f 100644 --- a/packages/web-components/src/accordion/fixtures/base.html +++ b/packages/web-components/src/accordion/fixtures/base.html @@ -1,9 +1,5 @@