diff --git a/change/@fluentui-eslint-plugin-83433d10-e2cd-4770-9d92-67bb16949a8a.json b/change/@fluentui-eslint-plugin-83433d10-e2cd-4770-9d92-67bb16949a8a.json new file mode 100644 index 0000000000000..35ae0150f9795 --- /dev/null +++ b/change/@fluentui-eslint-plugin-83433d10-e2cd-4770-9d92-67bb16949a8a.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Turn off react/jsx-no-bind rule for cypress component test files.", + "packageName": "@fluentui/eslint-plugin", + "email": "tristan.watanabe@gmail.com", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-dialog-79b6c18e-0e77-459b-bb58-b56343e43485.json b/change/@fluentui-react-dialog-79b6c18e-0e77-459b-bb58-b56343e43485.json new file mode 100644 index 0000000000000..a4831efba10f2 --- /dev/null +++ b/change/@fluentui-react-dialog-79b6c18e-0e77-459b-bb58-b56343e43485.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "chore: remove unneeded eslint rule line disables.", + "packageName": "@fluentui/react-dialog", + "email": "tristan.watanabe@gmail.com", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-menu-a5ada429-92db-4447-a6db-e909b652516e.json b/change/@fluentui-react-menu-a5ada429-92db-4447-a6db-e909b652516e.json new file mode 100644 index 0000000000000..319f3220d8731 --- /dev/null +++ b/change/@fluentui-react-menu-a5ada429-92db-4447-a6db-e909b652516e.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "chore: remove unneeded eslint rule line disables.", + "packageName": "@fluentui/react-menu", + "email": "tristan.watanabe@gmail.com", + "dependentChangeType": "none" +} diff --git a/change/@fluentui-react-popover-23aa3f07-0bc1-4817-bd9d-677738de8781.json b/change/@fluentui-react-popover-23aa3f07-0bc1-4817-bd9d-677738de8781.json new file mode 100644 index 0000000000000..9f4840741b7f2 --- /dev/null +++ b/change/@fluentui-react-popover-23aa3f07-0bc1-4817-bd9d-677738de8781.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "chore: remove unneeded eslint rule line disables.", + "packageName": "@fluentui/react-popover", + "email": "tristan.watanabe@gmail.com", + "dependentChangeType": "none" +} diff --git a/packages/eslint-plugin/src/configs/react.js b/packages/eslint-plugin/src/configs/react.js index 4b8d2936aed14..441a1997ee8d0 100644 --- a/packages/eslint-plugin/src/configs/react.js +++ b/packages/eslint-plugin/src/configs/react.js @@ -48,6 +48,7 @@ module.exports = { files: ['**/*.cy.{ts,tsx,js}', 'isConformant.{ts,tsx,js}'], rules: { 'import/no-extraneous-dependencies': 'off', + 'react/jsx-no-bind': 'off', }, }, ], diff --git a/packages/react-components/react-dialog/src/components/Dialog/Dialog.cy.tsx b/packages/react-components/react-dialog/src/components/Dialog/Dialog.cy.tsx index bc6f5d7861a3a..b94fb96c776b1 100644 --- a/packages/react-components/react-dialog/src/components/Dialog/Dialog.cy.tsx +++ b/packages/react-components/react-dialog/src/components/Dialog/Dialog.cy.tsx @@ -184,7 +184,6 @@ describe('Dialog', () => { } }, [open]); return ( - //eslint-disable-next-line react/jsx-no-bind setOpen(data.open)}> diff --git a/packages/react-components/react-menu/src/components/Menu/Menu.cy.tsx b/packages/react-components/react-menu/src/components/Menu/Menu.cy.tsx index aa97d3a7a186a..916adec9696e6 100644 --- a/packages/react-components/react-menu/src/components/Menu/Menu.cy.tsx +++ b/packages/react-components/react-menu/src/components/Menu/Menu.cy.tsx @@ -150,7 +150,6 @@ describe('Custom Trigger', () => { }; return ( - // eslint-disable-next-line react/jsx-no-bind @@ -714,7 +713,6 @@ describe(`Nested Menus`, () => { }; return ( - // eslint-disable-next-line react/jsx-no-bind Editor Layout @@ -738,7 +736,6 @@ describe(`Nested Menus`, () => { }; return ( - // eslint-disable-next-line react/jsx-no-bind Appearance @@ -763,7 +760,6 @@ describe(`Nested Menus`, () => { }; return ( - // eslint-disable-next-line react/jsx-no-bind Preferences diff --git a/packages/react-components/react-popover/src/components/Popover/Popover.cy.tsx b/packages/react-components/react-popover/src/components/Popover/Popover.cy.tsx index 78935f56ba931..69c846e7b137e 100644 --- a/packages/react-components/react-popover/src/components/Popover/Popover.cy.tsx +++ b/packages/react-components/react-popover/src/components/Popover/Popover.cy.tsx @@ -29,7 +29,6 @@ describe('Popover', () => { const [open, setOpen] = React.useState(false); return ( - // eslint-disable-next-line react/jsx-no-bind setOpen(data.open)}> @@ -297,7 +296,6 @@ describe('Popover', () => { }; return ( - // eslint-disable-next-line react/jsx-no-bind