From 0148868cd51db2e7f2beeb98da8d081c39401273 Mon Sep 17 00:00:00 2001 From: eljefe223 Date: Thu, 17 Dec 2020 10:45:05 -0800 Subject: [PATCH 1/3] fix: focus styling inconsistencies --- packages/web-components/src/styles/patterns/button.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-components/src/styles/patterns/button.ts b/packages/web-components/src/styles/patterns/button.ts index 60bc039b884ee0..514fc2284dc1c0 100644 --- a/packages/web-components/src/styles/patterns/button.ts +++ b/packages/web-components/src/styles/patterns/button.ts @@ -423,8 +423,8 @@ export const OutlineButtonStyles = css` } :host(.outline) .control:${focusVisible} { - border: calc(var(--outline-width) * 1px) solid ${neutralFocusBehavior.var}); box-shadow: 0 0 0 calc((var(--focus-outline-width) - var(--outline-width)) * 1px) ${neutralFocusBehavior.var}; + border-color: ${neutralFocusBehavior.var}; } :host(.outline.disabled) { From 8d67bae5ab2acee9cba3e1821ddc1596780a747c Mon Sep 17 00:00:00 2001 From: eljefe223 Date: Thu, 17 Dec 2020 10:45:34 -0800 Subject: [PATCH 2/3] Change files --- ...ents-2020-12-17-10-45-34-userrs-jes-focus-styling.json | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 change/@fluentui-web-components-2020-12-17-10-45-34-userrs-jes-focus-styling.json diff --git a/change/@fluentui-web-components-2020-12-17-10-45-34-userrs-jes-focus-styling.json b/change/@fluentui-web-components-2020-12-17-10-45-34-userrs-jes-focus-styling.json new file mode 100644 index 00000000000000..e2a22c44e566ac --- /dev/null +++ b/change/@fluentui-web-components-2020-12-17-10-45-34-userrs-jes-focus-styling.json @@ -0,0 +1,8 @@ +{ + "type": "patch", + "comment": "fix: focus styling inconsistencies", + "packageName": "@fluentui/web-components", + "email": "jes@microsoft.com", + "dependentChangeType": "patch", + "date": "2020-12-17T18:45:34.045Z" +} From 51772e2580d06de5e880fc8d7e0d488f09986002 Mon Sep 17 00:00:00 2001 From: eljefe223 Date: Thu, 17 Dec 2020 14:04:30 -0800 Subject: [PATCH 3/3] bump package --- packages/web-components/package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/web-components/package.json b/packages/web-components/package.json index bcb61254570600..07d7861ceed983 100644 --- a/packages/web-components/package.json +++ b/packages/web-components/package.json @@ -95,7 +95,7 @@ "@microsoft/fast-colors": "^5.1.0", "@microsoft/fast-components-styles-msft": "^4.29.0", "@microsoft/fast-element": "^0.21.1", - "@microsoft/fast-foundation": "^1.11.0", + "@microsoft/fast-foundation": "^1.11.1", "tslib": "^1.13.0" }, "beachball": { diff --git a/yarn.lock b/yarn.lock index 11477450323268..88c77627e1d046 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2419,10 +2419,10 @@ resolved "https://registry.yarnpkg.com/@microsoft/fast-element/-/fast-element-0.21.1.tgz#366fb006608819edf8053e0fbdb31618957b86a4" integrity sha512-DZVu9KGtwP+vg9z6fAHpiPntPPFNj4ex6qBSsRLP5RP8akqD54OiUokRTJ9/JodIF7R9w34XLG3EJRD75LQwDQ== -"@microsoft/fast-foundation@^1.11.0": - version "1.11.0" - resolved "https://registry.yarnpkg.com/@microsoft/fast-foundation/-/fast-foundation-1.11.0.tgz#c609fea459bebf41d49e715649c33334fe04af1b" - integrity sha512-ZbRrHKuN4xfnoxFHb8bmWPQHzOxC39KucL4CQ0hE8GRfNI38QbIAUNhVwgohsQWaKgiWv9soQr8kf94jdmaQow== +"@microsoft/fast-foundation@^1.11.1": + version "1.11.1" + resolved "https://registry.yarnpkg.com/@microsoft/fast-foundation/-/fast-foundation-1.11.1.tgz#d3e04c55be7a51b7cf38ef2acfe6eb3cbb0aec27" + integrity sha512-tRgx6MbfbyArzRhBwkki+MjB98tSbTRjgZ+pq3HiPtRE8leoi0kkNqcj+9+xuPSvzxU+u8eG2ySuOtTzk7VskA== dependencies: "@microsoft/fast-element" "^0.21.1" "@microsoft/fast-web-utilities" "^4.7.0"