Skip to content

chore(tools): bootstrap nx workpsace-tools and create workspace generator #18194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 18, 2021
Merged

chore(tools): bootstrap nx workpsace-tools and create workspace generator #18194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
965e38d
chore(tools): bootstrap nx workpsace-tools and create workspace gener…
Hotell May 14, 2021
e455e6c
chore: turn off syncpack for devDeps as we are moving to single versi…
Hotell May 17, 2021
72e2b02
chore: fix nx workpsace files to be up to date with current repo state
Hotell May 17, 2021
e078c5b
chore: add /tools to codeowners
Hotell May 17, 2021
d43f41e
ci: add nx workspace-lint check
Hotell May 17, 2021
73ff4df
chore: remove workspace & nx.json from implicit deps - they are prope…
Hotell May 17, 2021
45847b9
fix(scripts): properly import chalk for nodejs
Hotell May 17, 2021
b6bd54d
chore(react-conformance): revert chalk version to use range and to no…
Hotell May 17, 2021
fbf4ec1
chore(tools): incorporate tools/ into existing ci pipeline
Hotell May 17, 2021
e702fc7
Change files
Hotell May 17, 2021
9586859
Change files
Hotell May 17, 2021
e8f7adc
chore: define version group for monorepo root package.json and revert…
Hotell May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
/.storybook/ @microsoft/fluentui-react-build
/.vscode/ @microsoft/fluentui-react-build
/scripts/ @microsoft/fluentui-react-build
/tools @microsoft/fluentui-react-build

#### Root Build files
/.eslintrc.* @microsoft/fluentui-react-build
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ gitignore
*.svg
*.txt
*.mdx
.gitkeep
*__tmpl__
*__template__

# template files which actually follow a different language's formatting
*.hbs
4 changes: 4 additions & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ jobs:
yarn checkchange
displayName: check change

- script: |
yarn nx workspace-lint
displayName: nx:workspace-lint
Copy link
Contributor Author

@Hotell Hotell May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run nx workspace lint checks on ci to prevent getting out of sync whilst doing changes by hand


- script: |
if [[ -n "$(targetBranch)" ]]; then
yarn format --since $(targetBranch) --check
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-react-conformance-a23545f7-d46d-4adf-abfa-ca4977662b63.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "chore(react-conformance): revert chalk version to use range and to not clash with single version policy for devtooling",
"packageName": "@fluentui/react-conformance",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-examples-e0e461cf-e362-4de2-8c40-a293bbea4132.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "fixup! fixup! fixup! fixup! fix(scripts): properly import chalk for nodejs",
"packageName": "@fluentui/react-examples",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-menu-1e44c9a4-7c66-4d25-af10-975074729342.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "fixup! fixup! fixup! fix(scripts): properly import chalk for nodejs",
"packageName": "@fluentui/react-menu",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-monaco-editor-d7a54aa5-0c62-4390-a2b1-a486e00e1a00.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "fixup! fix(scripts): properly import chalk for nodejs",
"packageName": "@fluentui/react-monaco-editor",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
projects: ['<rootDir>/packages/react-menu', '<rootDir>/packages/react-storybook'],
projects: ['<rootDir>/tools', '<rootDir>/packages/react-menu', '<rootDir>/packages/react-storybook'],
};
Loading