fix(ChatMessage): remove compactBody default prop from ChatMessage #18874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chpalac
requested review from
jurokapsiar,
layershifter,
ling1726,
miroslavstastny and
pompomon
as code owners
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
Contributor
|
Sorry could you put some more details in the description, the problem is not clear to me |
Contributor
Author
Having Error:
|
Asset size changes
Baseline commit: 2b6f9b68a6d4ba683ccb10b462b1e2a897b20cc5 (build) |
chpalac
changed the title
ling1726
approved these changes
Jul 9, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2312f08:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 811 | 787 | 5000 | |
| BaseButton | mount | 887 | 876 | 5000 | |
| Breadcrumb | mount | 2591 | 2527 | 1000 | |
| ButtonNext | mount | 521 | 492 | 5000 | |
| Checkbox | mount | 1530 | 1462 | 5000 | |
| CheckboxBase | mount | 1333 | 1287 | 5000 | |
| ChoiceGroup | mount | 4687 | 4633 | 5000 | |
| ComboBox | mount | 971 | 967 | 1000 | |
| CommandBar | mount | 10039 | 10050 | 1000 | |
| ContextualMenu | mount | 6165 | 6221 | 1000 | |
| DefaultButton | mount | 1132 | 1123 | 5000 | |
| DetailsRow | mount | 3611 | 3720 | 5000 | |
| DetailsRowFast | mount | 3676 | 3763 | 5000 | |
| DetailsRowNoStyles | mount | 3581 | 3545 | 5000 | |
| Dialog | mount | 2086 | 2123 | 1000 | |
| DocumentCardTitle | mount | 140 | 130 | 1000 | |
| Dropdown | mount | 3213 | 3156 | 5000 | |
| FluentProviderNext | mount | 7264 | 7330 | 5000 | |
| FocusTrapZone | mount | 1756 | 1760 | 5000 | |
| FocusZone | mount | 1805 | 1779 | 5000 | |
| IconButton | mount | 1689 | 1725 | 5000 | |
| Label | mount | 350 | 350 | 5000 | |
| Layer | mount | 1768 | 1766 | 5000 | |
| Link | mount | 460 | 471 | 5000 | |
| MakeStyles | mount | 1820 | 1816 | 50000 | |
| MenuButton | mount | 1416 | 1446 | 5000 | |
| MessageBar | mount | 2016 | 2063 | 5000 | |
| Nav | mount | 3203 | 3208 | 1000 | |
| OverflowSet | mount | 1016 | 997 | 5000 | |
| Panel | mount | 2063 | 2041 | 1000 | |
| Persona | mount | 805 | 823 | 1000 | |
| Pivot | mount | 1401 | 1410 | 1000 | |
| PrimaryButton | mount | 1275 | 1289 | 5000 | |
| Rating | mount | 7470 | 7620 | 5000 | |
| SearchBox | mount | 1343 | 1301 | 5000 | |
| Shimmer | mount | 2431 | 2507 | 5000 | |
| Slider | mount | 1915 | 1921 | 5000 | |
| SpinButton | mount | 4949 | 4930 | 5000 | |
| Spinner | mount | 412 | 417 | 5000 | |
| SplitButton | mount | 3084 | 3056 | 5000 | |
| Stack | mount | 495 | 505 | 5000 | |
| StackWithIntrinsicChildren | mount | 1559 | 1511 | 5000 | |
| StackWithTextChildren | mount | 4490 | 4545 | 5000 | |
| SwatchColorPicker | mount | 10072 | 10062 | 5000 | |
| Tabs | mount | 1395 | 1356 | 1000 | |
| TagPicker | mount | 2393 | 2325 | 5000 | |
| TeachingBubble | mount | 11787 | 11769 | 5000 | |
| Text | mount | 420 | 412 | 5000 | |
| TextField | mount | 1358 | 1356 | 5000 | |
| ThemeProvider | mount | 1161 | 1189 | 5000 | |
| ThemeProvider | virtual-rerender | 596 | 591 | 5000 | |
| Toggle | mount | 814 | 797 | 5000 | |
| buttonNative | mount | 117 | 121 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| FormMinimalPerf.default | 409 | 375 | 1.09:1 |
| ChatDuplicateMessagesPerf.default | 300 | 280 | 1.07:1 |
| ButtonMinimalPerf.default | 170 | 161 | 1.06:1 |
| PortalMinimalPerf.default | 183 | 173 | 1.06:1 |
| AvatarMinimalPerf.default | 192 | 185 | 1.04:1 |
| AlertMinimalPerf.default | 285 | 276 | 1.03:1 |
| AttachmentMinimalPerf.default | 154 | 149 | 1.03:1 |
| ButtonSlotsPerf.default | 539 | 521 | 1.03:1 |
| CarouselMinimalPerf.default | 464 | 450 | 1.03:1 |
| DatepickerMinimalPerf.default | 5411 | 5272 | 1.03:1 |
| GridMinimalPerf.default | 332 | 323 | 1.03:1 |
| DialogMinimalPerf.default | 761 | 748 | 1.02:1 |
| DividerMinimalPerf.default | 365 | 358 | 1.02:1 |
| DropdownManyItemsPerf.default | 671 | 661 | 1.02:1 |
| HeaderMinimalPerf.default | 363 | 355 | 1.02:1 |
| HeaderSlotsPerf.default | 745 | 728 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1229 | 1204 | 1.02:1 |
| MenuMinimalPerf.default | 837 | 820 | 1.02:1 |
| ProviderMinimalPerf.default | 1019 | 1003 | 1.02:1 |
| RefMinimalPerf.default | 241 | 236 | 1.02:1 |
| SegmentMinimalPerf.default | 340 | 334 | 1.02:1 |
| StatusMinimalPerf.default | 667 | 651 | 1.02:1 |
| TreeMinimalPerf.default | 781 | 762 | 1.02:1 |
| TreeWith60ListItems.default | 179 | 175 | 1.02:1 |
| VideoMinimalPerf.default | 643 | 629 | 1.02:1 |
| BoxMinimalPerf.default | 340 | 335 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1674 | 1664 | 1.01:1 |
| ChatMinimalPerf.default | 652 | 645 | 1.01:1 |
| CheckboxMinimalPerf.default | 2743 | 2720 | 1.01:1 |
| DropdownMinimalPerf.default | 3108 | 3091 | 1.01:1 |
| InputMinimalPerf.default | 1264 | 1253 | 1.01:1 |
| LabelMinimalPerf.default | 389 | 384 | 1.01:1 |
| LoaderMinimalPerf.default | 692 | 682 | 1.01:1 |
| PopupMinimalPerf.default | 571 | 568 | 1.01:1 |
| IconMinimalPerf.default | 610 | 603 | 1.01:1 |
| TableManyItemsPerf.default | 1909 | 1893 | 1.01:1 |
| CustomToolbarPrototype.default | 3859 | 3827 | 1.01:1 |
| TooltipMinimalPerf.default | 968 | 955 | 1.01:1 |
| AttachmentSlotsPerf.default | 1062 | 1058 | 1:1 |
| CardMinimalPerf.default | 541 | 541 | 1:1 |
| EmbedMinimalPerf.default | 4094 | 4075 | 1:1 |
| FlexMinimalPerf.default | 281 | 282 | 1:1 |
| ListNestedPerf.default | 552 | 551 | 1:1 |
| TableMinimalPerf.default | 409 | 407 | 1:1 |
| TextAreaMinimalPerf.default | 496 | 498 | 1:1 |
| AnimationMinimalPerf.default | 402 | 407 | 0.99:1 |
| ChatWithPopoverPerf.default | 351 | 356 | 0.99:1 |
| LayoutMinimalPerf.default | 350 | 352 | 0.99:1 |
| ListCommonPerf.default | 609 | 614 | 0.99:1 |
| ListMinimalPerf.default | 496 | 501 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1551 | 1567 | 0.99:1 |
| SkeletonMinimalPerf.default | 350 | 353 | 0.99:1 |
| SliderMinimalPerf.default | 1591 | 1599 | 0.99:1 |
| SplitButtonMinimalPerf.default | 3702 | 3743 | 0.99:1 |
| ToolbarMinimalPerf.default | 914 | 919 | 0.99:1 |
| AccordionMinimalPerf.default | 144 | 147 | 0.98:1 |
| ProviderMergeThemesPerf.default | 1664 | 1691 | 0.98:1 |
| RadioGroupMinimalPerf.default | 434 | 441 | 0.98:1 |
| ReactionMinimalPerf.default | 376 | 383 | 0.98:1 |
| TextMinimalPerf.default | 352 | 361 | 0.98:1 |
| ListWith60ListItems.default | 623 | 640 | 0.97:1 |
| RosterPerf.default | 1123 | 1205 | 0.93:1 |
| ImageMinimalPerf.default | 342 | 372 | 0.92:1 |
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
…icrosoft#18874) * fix: remove compactBody default prop from ChatMessage * add changelog Co-authored-by: Charles Assuncao <charles.assuncao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Remove
compactBodyfromChatMessageto avoid conflict withchildrenHaving compactBody as a itemShorthand conflicts with children throwing an error complaining about having children and compactBody defined.
Error:
Prop
compactBodyinChatMessageconflicts with props:children. They cannot be defined together, choose one or the other.Focus areas to test
(optional)