From b677ab8ce2ef6487b9e5844bf419a2bb25f6ef4a Mon Sep 17 00:00:00 2001 From: Simon Chan <1330321+yume-chan@users.noreply.github.com> Date: Wed, 16 Nov 2022 12:26:03 +0800 Subject: [PATCH 1/2] fix(react-file-type-icons): return correct icon name for documentsFolder --- .../src/getFileTypeIconProps.test.ts | 15 +++++++++++++++ .../src/getFileTypeIconProps.ts | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 packages/react-file-type-icons/src/getFileTypeIconProps.test.ts diff --git a/packages/react-file-type-icons/src/getFileTypeIconProps.test.ts b/packages/react-file-type-icons/src/getFileTypeIconProps.test.ts new file mode 100644 index 0000000000000..914ab03240acf --- /dev/null +++ b/packages/react-file-type-icons/src/getFileTypeIconProps.test.ts @@ -0,0 +1,15 @@ +import { FileIconType } from './FileIconType'; +import { FileTypeIconMap } from './FileTypeIconMap'; +import { getFileTypeIconNameFromExtensionOrType } from './getFileTypeIconProps'; + +describe('return valid icon name', () => { + it('returns an icon name in file type icon map', () => { + for (const key of Object.keys(FileIconType)) { + // Iterate through a TypeScript enum + const value = FileIconType[(key as unknown) as FileIconType]; + if (typeof value === 'number') { + expect(FileTypeIconMap).toHaveProperty(getFileTypeIconNameFromExtensionOrType(undefined, value)); + } + } + }); +}); diff --git a/packages/react-file-type-icons/src/getFileTypeIconProps.ts b/packages/react-file-type-icons/src/getFileTypeIconProps.ts index ccae563c358e9..1898b9623da8f 100644 --- a/packages/react-file-type-icons/src/getFileTypeIconProps.ts +++ b/packages/react-file-type-icons/src/getFileTypeIconProps.ts @@ -14,7 +14,7 @@ const MULTIPLE_ITEMS = 'multiple'; const NEWS = 'sponews'; const STREAM = 'video'; const DESKTOP_FOLDER = 'desktopfolder'; -const DOCUMENTS_FOLDER = 'documentfolder'; +const DOCUMENTS_FOLDER = 'documentsfolder'; const PICTURES_FOLDER = 'picturesfolder'; const LINKED_FOLDER = 'linkedfolder'; const FORM = 'form'; From 8009f155925a324ecb466f9b54acaab6da6d7c0d Mon Sep 17 00:00:00 2001 From: Simon Chan <1330321+yume-chan@users.noreply.github.com> Date: Wed, 16 Nov 2022 12:30:15 +0800 Subject: [PATCH 2/2] add change file --- ...le-type-icons-73c2ddb0-ff78-4e33-87a8-dafa7d543252.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-file-type-icons-73c2ddb0-ff78-4e33-87a8-dafa7d543252.json diff --git a/change/@fluentui-react-file-type-icons-73c2ddb0-ff78-4e33-87a8-dafa7d543252.json b/change/@fluentui-react-file-type-icons-73c2ddb0-ff78-4e33-87a8-dafa7d543252.json new file mode 100644 index 0000000000000..dc7641c93517f --- /dev/null +++ b/change/@fluentui-react-file-type-icons-73c2ddb0-ff78-4e33-87a8-dafa7d543252.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "fix: return correct icon name for documentsFolder", + "packageName": "@fluentui/react-file-type-icons", + "email": "1330321+yume-chan@users.noreply.github.com", + "dependentChangeType": "patch" +}