Fix for port conflict with docker daemon. #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a flag exposed for docker to avoid port reservation conflict with external port HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set (cherry picked from commit b85f3fd) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
|
I assume we'll need to get out a tag of hcsshim containing this and get it into moby? |
|
@dcantah - Yes, we'll need a tag. Also, if this looks good, will put up a PR against hcsshim's moby branch for backport. |
kestratt
approved these changes
Apr 22, 2022
anmaxvl
approved these changes
Apr 25, 2022
ameyag
added a commit
to ameyag/hcsshim
that referenced
this pull request
Apr 25, 2022
… a flag exposed for docker to avoid port reservation conflict with external port (microsoft#1370) HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set (cherry picked from commit b85f3fd) Signed-off-by: Ameya Gawde <agawde@mirantis.com> Co-authored-by: Kendall Stratton <kestratt@microsoft.com> (cherry picked from commit dbb347e) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
ameyag
added a commit
to ameyag/hcsshim
that referenced
this pull request
Apr 25, 2022
… a flag exposed for docker to avoid port reservation conflict with external port (microsoft#1370) HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set (cherry picked from commit b85f3fd) Signed-off-by: Ameya Gawde <agawde@mirantis.com> Co-authored-by: Kendall Stratton <kestratt@microsoft.com> (cherry picked from commit dbb347e) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
ameyag
added a commit
to ameyag/hcsshim
that referenced
this pull request
May 2, 2022
… a flag exposed for docker to avoid port reservation conflict with external port (microsoft#1370) HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set (cherry picked from commit b85f3fd) Signed-off-by: Ameya Gawde <agawde@mirantis.com> Co-authored-by: Kendall Stratton <kestratt@microsoft.com> (cherry picked from commit dbb347e) Signed-off-by: Ameya Gawde <agawde@mirantis.com>
dcantah
pushed a commit
that referenced
this pull request
May 2, 2022
… a flag exposed for docker to avoid port reservation conflict with external port (#1370) (#1373) HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set (cherry picked from commit b85f3fd) Signed-off-by: Ameya Gawde <agawde@mirantis.com> Co-authored-by: Kendall Stratton <kestratt@microsoft.com> (cherry picked from commit dbb347e) Signed-off-by: Ameya Gawde <agawde@mirantis.com> Co-authored-by: Kendall Stratton <kestratt@microsoft.com>
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
… a flag exposed for docker to avoid port reservation conflict with external port (microsoft#1370) HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set (cherry picked from commit b85f3fd) Signed-off-by: Ameya Gawde <agawde@mirantis.com> Co-authored-by: Kendall Stratton <kestratt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libnetwork logic uses a dummy proxy to bind the ports for communication between container and host. WS 2019 Aug 2020 patch onwards, Windows started doing an early port reservation which conflicts with the aforementioned logic for overlay and host publish mode for the ports.
Adding ExternalPortReserved flag to NatPolicy for HNS API V1. This is a flag exposed for docker to avoid port reservation conflict with external port
HNS API V2 will use NatFlags to check and see if ExternalPortReserved is set
(cherry picked from commit b85f3fd)
Signed-off-by: Ameya Gawde agawde@mirantis.com
Verified the fix with private HostNetSvc.dll from Windows networking team and corresponding change on libnetwork to send down the flag
ExternalPortReserved