Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request batching #988

Open
dbaeumer opened this issue May 18, 2020 · 2 comments
Open

Request batching #988

dbaeumer opened this issue May 18, 2020 · 2 comments
Labels
feature-request Request for new features or functionality new request
Milestone

Comments

@dbaeumer
Copy link
Member

The protocol defines quite some message which are executed on a text document (e.g. folding ranges, document links, colors, ...). Clients usually send these request after a timeout ask the server to recompute the responses after the user typed. Since these request require to reconcile the AST and even may be resolving symbols it would be useful for a server to know that a client will ask for on of these requests. To support such an optimization we should look into batch n requests. Two ideas:

  • have special LSP level notifications for this. This is comparable to begin/end transaction in DBs.
  • use JSON RPC Batching (https://www.jsonrpc.org/specification#batch). Downside is that most RPC libraries have no support for this.
@strager
Copy link
Contributor

strager commented Jan 26, 2023

use JSON RPC Batching (https://www.jsonrpc.org/specification#batch). Downside is that most RPC libraries have no support for this.

I noticed the lack of support as well. I decided to make the status quo explicit: #1651

@ddickstein
Copy link

Should this issue be closed if support is not planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality new request
Projects
None yet
Development

No branches or pull requests

3 participants