Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

code cleaning and adding savemode checks to writer #43

Merged
merged 7 commits into from
Jan 28, 2020

Conversation

gramhagen
Copy link
Contributor

general code cleaning

adding mode check to datawriter to address #37, still need to finish test case, but

File propsFile = new File("target/accumulo2-maven-plugin/spark-connector-instance");

refers to a file that isn't in the project.
@eisber, can you add the property file you're using to this branch under integration-test/src/resources?

@eisber
Copy link
Collaborator

eisber commented Jan 7, 2020

I think this file gets generated when running the test (or integration test code) by the accumulo mini cluster maven task.

@gramhagen gramhagen changed the title [WIP] code cleaning and adding savemode checks to writer code cleaning and adding savemode checks to writer Jan 22, 2020

val client = Accumulo.newClient().from(properties).build()
client.close()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use try { } finally { }

@gramhagen gramhagen merged commit 32c867a into master Jan 28, 2020
@gramhagen gramhagen deleted the scgraham/savemode branch January 28, 2020 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants