Skip to content

Commit

Permalink
TabView API Spec (#43)
Browse files Browse the repository at this point in the history
* TabControl Spec (#28)

* Create tabcontrol.md

* Removed initial comment

* Starting filling in content

* Added backlink to Proposal

* Added links to Pivot, NavigationView

* Add sample for putting tabs in titlebar

* Fill out sample for tab tear off

* Update title format to be more readable

* Adding sample image files for tabs in titlebar and in new window

* Reference the new images in the doc

* Rearrange samples based on expected usage

* Update tabcontrol.md

* Update tabcontrol.md

* Clarified Tabs in Titlebar sample

* Update Edge sample with new tab button style

* Clarified CloseButtonOverlay default

* Added default TabWidthBehavior description

* Adding some Open Questions

Adding some open questions to the open questions section that were brought up in the PR.

* Updated Keyboard sections

* Cleaned up the API to minimize the v1 surface area

* Remove open questions that have been answered

* Updating the API section now that TabView CONTAINS a ListView insead of IS A ListView

* More API changes resulting from containing a ListView instead of being a ListView

* Updating images to reflect current API spec

* Adding placeholder sections for samples that need to be written

* Update link to new images from png to PNG

* Rename from TabControl to TabView

* Add sample showing keyboarding

* Add sample of the Add Tab button and handler

* Rename TabItem to TabViewItem

* AddButtonCommand and Parameter, as well as ItemTemplateSelector properties

* Update active/tab/tabcontrol.md

Update the description of the TabView-in-titlebar sample based on feedback.

Co-Authored-By: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com>

* Update instances of Tab to TabView

* Update AddButton APIs to AddTabButton

* Update wording in keyboarding section

* Updated to include IDL and some slight name changes across the doc to align between spec and IDL

* Update keyboarding section to separate built-in functionality/examples from app guidance

* Remove TODO for recombination sample. This will be shown in a separate sample as its too complex for the spec

* Update Tab Control to TabView

* Update Item to TabItem

* API Feedback: 1st sample

* API Feedback: TabDraggedOutside --> TabDroppedOutside

* API Feedback: Update TabItems to type IVector<TabViewItem>

* API Feedback: s/fire/raise

* API Feedback: Remove Cancel from TabViewTabClosingEventArgs

* API Feedback: Update ItemTemplate to TabContentTemplate. Added TabHeaderTemplate.

* Rename TabViewItemWidthMode --> TabWidthMode, and updated enum to TabViewTabWidthMode

* API Feedback: Remove TODOs

* API Feedback: Remove TabView.CanCloseTabs

* API Feedback: Change Item to Tab in TabViewTabClosingEventArgs

* API Feedback: Add TabViewItemDroppedOutsideEventArgs

* API Feedback: Update TabDroppedOutside event args to have typed sender

* API Feedback: Update custom drag region min width

* Update TabClosing to TabCloseRequested

* API Feedback: Update descriptions for Tab content vs header

* API Feedback: Clarify behavior when too many tabs are visible and bumpers show

* API Feedback: Move pictures to remarks and update text based on latest naming

* Add TabCloseRequested to basic sample

* API Feedback: Update IDL to reflect latest feedback.

* API Feedback: Add note about selected items.

* API Feedback: Simplify the basic add tab sample

* Update instances of tab spacing to space spacing

* API Feedback: Update TabItemTemplate

* API Feedback: Update titlebar sample

* API Feedback: Update multi-window sample image and text

* API Feedback: Update images

* Add visual design mockups to appendix

* API Feedback: Update IDL. CanDragTabs = false and SelectedIndex = 0
  • Loading branch information
stmoy authored Aug 30, 2019
1 parent 9b44431 commit e23de4d
Show file tree
Hide file tree
Showing 14 changed files with 637 additions and 0 deletions.
Binary file added active/tab/images/TabView_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/TabView_dark_accent.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/TabView_light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/TabView_light_accent.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-control-keyboarding-1.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-control-keyboarding-2.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-control-keyboarding-3.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-control-parts-1.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-control-parts-2.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-control-parts-3.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-extend-to-title.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-new-window.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added active/tab/images/tab-overview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
637 changes: 637 additions & 0 deletions active/tab/tabcontrol.md

Large diffs are not rendered by default.

0 comments on commit e23de4d

Please sign in to comment.