New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView API Spec #43

Merged

stmoy merged 29 commits into master from user/stmoy/tabview_API_review

Aug 30, 2019

Contributor

stmoy commented Jul 31, 2019

Spec review for TabView.

(See #28 for full history/comments)


          TabControl Spec (#28)

149c4c1

* Create tabcontrol.md

* Removed initial comment

* Starting filling in content

* Added backlink to Proposal

* Added links to Pivot, NavigationView

* Add sample for putting tabs in titlebar

* Fill out sample for tab tear off

* Update title format to be more readable

* Adding sample image files for tabs in titlebar and in new window

* Reference the new images in the doc

* Rearrange samples based on expected usage

* Update tabcontrol.md

* Update tabcontrol.md

* Clarified Tabs in Titlebar sample

* Update Edge sample with new tab button style

* Clarified CloseButtonOverlay default

* Added default TabWidthBehavior description

* Adding some Open Questions

Adding some open questions to the open questions section that were brought up in the PR.

* Updated Keyboard sections

* Cleaned up the API to minimize the v1 surface area

* Remove open questions that have been answered

* Updating the API section now that TabView CONTAINS a ListView insead of IS A ListView

* More API changes resulting from containing a ListView instead of being a ListView

* Updating images to reflect current API spec

* Adding placeholder sections for samples that need to be written

* Update link to new images from png to PNG

* Rename from TabControl to TabView

* Add sample showing keyboarding

* Add sample of the Add Tab button and handler

* Rename TabItem to TabViewItem

* AddButtonCommand and Parameter, as well as ItemTemplateSelector properties

* Update active/tab/tabcontrol.md

Update the description of the TabView-in-titlebar sample based on feedback.

Co-Authored-By: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com>

* Update instances of Tab to TabView

* Update AddButton APIs to AddTabButton

* Update wording in keyboarding section

* Updated to include IDL and some slight name changes across the doc to align between spec and IDL

* Update keyboarding section to separate built-in functionality/examples from app guidance

* Remove TODO for recombination sample. This will be shown in a separate sample as its too complex for the spec

* Update Tab Control to TabView

* Update Item to TabItem

stmoy requested a review from a team as a code owner

July 31, 2019 17:14

stmoy changed the title ~~TabView API Spec (#28)~~ TabView API Spec

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

MikeHillberg reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

stmoy added 14 commits

August 9, 2019 15:56


          API Feedback: Remove TODOs

4badcfa


          API Feedback: Remove TabView.CanCloseTabs

86cd2fc


          API Feedback: Change Item to Tab in TabViewTabClosingEventArgs

91cf291


          API Feedback: Add TabViewItemDroppedOutsideEventArgs

b623bd2


          API Feedback: Update TabDroppedOutside event args to have typed sender

74361b2


          API Feedback: Update custom drag region min width

bca5236


          Update TabClosing to TabCloseRequested

1d78ab3


          API Feedback: Update descriptions for Tab content vs header

e960f04


          API Feedback: Clarify behavior when too many tabs are visible and bum…

69cf5e4

…pers show


          API Feedback: Move pictures to remarks and update text based on lates…

b0819af

…t naming


          Add TabCloseRequested to basic sample

0419a34


          API Feedback: Update IDL to reflect latest feedback.

c0231c3


          API Feedback: Add note about selected items.

dc2e361


          API Feedback: Simplify the basic add tab sample

133604b

ExE-Boss reviewed

View reviewed changes

ExE-Boss left a comment

Since you’ve mostly switched to tabs in 133604b (🎉), you should finish the conversion fully, and not leave examples half‑converted.

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

Contributor Author

stmoy commented Aug 22, 2019

Since you’ve mostly switched to tabs in 133604b (🎉), you should finish the conversion fully, and not leave examples half‑converted.

@ExE-Boss - this was actually not my intent as we generally use spaces 😅 - Agreed that we don't want to have a mix of both though, thanks for the call out!

stmoy added 2 commits

August 22, 2019 16:43


          Update instances of tab spacing to space spacing

a184656


          API Feedback: Update TabItemTemplate

8b2049c

MikeHillberg reviewed

View reviewed changes

active/tab/tabcontrol.md Show resolved Hide resolved

active/tab/tabcontrol.md Show resolved Hide resolved

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

active/tab/tabcontrol.md Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

oldnewthing reviewed

View reviewed changes

active/tab/tabcontrol.md Outdated Show resolved Hide resolved

stmoy added 5 commits

August 27, 2019 14:03


          API Feedback: Update titlebar sample

94c87f8


          API Feedback: Update multi-window sample image and text

f30a92b


          API Feedback: Update images

0506e80


          Add visual design mockups to appendix

e54d61d


          API Feedback: Update IDL. CanDragTabs = false and SelectedIndex = 0

4eb94c0

stmoy requested a review from MikeHillberg

August 30, 2019 17:04

MikeHillberg approved these changes

View reviewed changes

stmoy merged commit e23de4d into master

stmoy mentioned this pull request

Proposal: TabView vNext microsoft/microsoft-ui-xaml#1332

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

teaP teaP left review comments

oldnewthing oldnewthing left review comments

mdtauk mdtauk left review comments

ExE-Boss ExE-Boss left review comments

MikeHillberg MikeHillberg approved these changes

Labels

None yet