Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RadialGradientBrush.GradientOriginOffset to GradientOrign and default to .5, .5 #2180

Closed
ranjeshj opened this issue Mar 27, 2020 · 6 comments · Fixed by #2181
Closed

Update RadialGradientBrush.GradientOriginOffset to GradientOrign and default to .5, .5 #2180

ranjeshj opened this issue Mar 27, 2020 · 6 comments · Fixed by #2181
Assignees
@marcelwgn
Labels
area-RadialGradientBrush team-Controls Issue for the Controls team

Comments

@ranjeshj
Copy link
Contributor

ranjeshj commented Mar 27, 2020 •
edited
Loading

We decided in the spec review to rename RadialGradientBrsh.GradientOrginOffset to GradientOrign to match what WPF does currently. We also want to move the starting point to top left and make the default .5,.5
@ranjeshj ranjeshj added team-Controls Issue for the Controls team area-RadialGradientBrush labels Mar 27, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Mar 27, 2020
@marcelwgn
Copy link
Collaborator

I would like to take this issue.

@marcelwgn marcelwgn mentioned this issue Mar 27, 2020
Merged
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Mar 27, 2020
@michael-hawker
Copy link
Collaborator

@ranjeshj doesn't WPF call the property GradientOrigin?

I'm a bit worried about the migration cost for folks coming from WPF, Silverlight, and the Windows Community Toolkit to the WinUI version with so many differences in property names and values.

@ranjeshj
Copy link
Contributor Author

@ranjeshj doesn't WPF call the property GradientOrigin?

I'm a bit worried about the migration cost for folks coming from WPF, Silverlight, and the Windows Community Toolkit to the WinUI version with so many differences in property names and values.

Yes.. This PR is trying to make us match WPF naming.

@marcelwgn
Copy link
Collaborator

But the WPF's name is GradientOrigin, while in your comment you said GradientOffset. So should we rename it to GradientOrigin then?

@ranjeshj
Copy link
Contributor Author

Sorry. I had the title correct and the description wrong. Yes it should match WPF.

@marcelwgn
Copy link
Collaborator

Thanks for clarification. PR is up to date now.

@michael-hawker michael-hawker mentioned this issue Apr 2, 2020
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcelwgn marcelwgn

Labels
area-RadialGradientBrush team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GradientOrigin property to align with WPF naming marcelwgn/microsoft-ui-xaml
5 participants
@StephenLPeters @marcelwgn @michael-hawker @ranjeshj @msft-github-bot