-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First check in of TabView #629
Conversation
Maybe an idea for the ToDo list. Tab Placement? Bottom, Left, Right. |
$controlDir = $muxControlsDir + "\dev\$projectName" | ||
|
||
# TODO: check if project directory exists | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test-Path ? or is this TODO more about "what should we do if it exists already?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some feedback, but nothing blocking. Can be addressed in a follow-up.
🎉 Handy links: |
TabView's current features are mostly drawn from the toolkit version. Names are not final; this is just a preliminary checkin to match the features given to Terminal for Build. For a list of things not in it currently (noteably, any accessibility work) check out the feature issue: #590
I discovered that accessibility tools cannot see anything, at all, inside the actual tab content. Huge problem that I haven't been able to fix yet. If anyone has any ideas, please let me know...