Add + button and fix tab column sizing #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llongley
requested changes
Jun 20, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
Austin-Lamb
reviewed
Jun 21, 2019
llongley
approved these changes
Jun 21, 2019
|
Is there an alternative "Plus" glyph that is smaller than 16 x 16 within the MDL2 Asset fonts? UWP Edge's glyph is 0xE710 and is used at a fontsize of 13, and fits in that 32 x 32 button space much more pleasingly.
|
jevansaks
added
the
release note
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a + button next to the tabs, IsAddButtonVisible property, and AddButtonClick event. Changed tests to use the new button and to test that visibility is hooked up properly. I originally had an accessibility change to go with this that made the + button (among other things) part of the accessible tree, but we've just decided to make TabView have a ListView instead of being a ListView so I've removed that part for now (since it won't be needed) and disabled the tests temporarily.
Also as part of this I discovered that the tab column was being sized incorrectly, so that the + button would never rest next to them; I fixed the logic so that the + and the right content area sit where they're supposed to.
I also updated colors as agreed upon by us and Terminal.