Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenCredential class shouldn't be required #2441

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Jun 5, 2024

Continuation of #2415.

Fixes #2439.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.12%. Comparing base (722c910) to head (3801686).
Report is 1 commits behind head on main.

Current head 3801686 differs from pull request most recent head ef3b3fc

Please upload reports for the commit ef3b3fc to get more accurate results.

Files Patch % Lines
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2441      +/-   ##
============================================
- Coverage     50.13%   50.12%   -0.02%     
+ Complexity     3842     3839       -3     
============================================
  Files           145      145              
  Lines         33409    33409              
  Branches       5667     5667              
============================================
- Hits          16750    16746       -4     
- Misses        14258    14266       +8     
+ Partials       2401     2397       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird added this to the 12.7.1 milestone Jun 10, 2024
@Jeffery-Wasty Jeffery-Wasty merged commit 2a33f9a into main Jun 11, 2024
15 of 17 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the removed-class-dependency branch June 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Azure TokenCredential class required if using Always Encrypted but not using Azure
4 participants