This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix prefix static source 404 issue #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lijiaoa
approved these changes
Aug 10, 2021
liuzhe-lz
reviewed
Aug 10, 2021
| @@ -38,7 +38,7 @@ export class NNIRestServer extends RestServer { | |||
| * NNIRestServer's own router registration | |||
| */ | |||
| protected registerRestHandler(): void { | |||
| this.app.use(express.static('static')); | |||
| this.app.use(getPrefixUrl(), express.static('static')) | |||
There was a problem hiding this comment.
Missing a semicolon here.
liuzhe-lz
reviewed
Aug 10, 2021
| @@ -126,3 +126,8 @@ export function getDispatcherPipe(): string | null { | |||
| export function getAPIRootUrl(): string { | |||
| return getExperimentStartupInfo().apiRootUrl; | |||
| } | |||
|
|
|||
| export function getPrefixUrl(): string { | |||
| const prefix = getExperimentStartupInfo().urlprefix === ''?'':`/${getExperimentStartupInfo().urlprefix}`; | |||
There was a problem hiding this comment.
Please add spaces around operators to make the style in sync with other codes.
There was a problem hiding this comment.
why not add lint for this format in next release?
added 2 commits
August 10, 2021 15:16
liuzhe-lz
approved these changes
Aug 10, 2021
ultmaster
approved these changes
Aug 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.