This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[fix issue#4015] webui prompts error message if user set maxExperimentDuration < execDuration #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
Sep 10, 2021
| if (toSeconds(`${editInputVal}${unit}`) < EXPERIMENT.profile.execDuration) { | ||
| // maxDuration should > current run time(execDuration) | ||
| promptErrorMessage( | ||
| 'Current duration is more than the number you input, please input effective value', |
There was a problem hiding this comment.
please input a valid value. (Current duration is ...)
There was a problem hiding this comment.
I had changed it to Please input a valid value. (Current duration is more than the number you input.). Please help review again~
78 tasks
liuzhe-lz
approved these changes
Sep 13, 2021
ultmaster
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue: #4015
maxExperimentDuration is more than execDuration by design.
webui will prompt error message now if user set maxExperimentDuration < execDuration.