This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add version check document in PAI, remote, kubeflow and frameworkcontroller #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SparkSnail
commented
Apr 1, 2019
•
SparkSnail
commented
- Add version check document
- Add try catch in gpu scheduler to fix UT
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
xuehui1991
reviewed
Apr 1, 2019
chicm-ms
approved these changes
Apr 2, 2019
yds05
reviewed
Apr 2, 2019
| await cpp.exec(`pkill -P ${pid}`); | ||
| await cpp.exec(`rm -rf ${this.gpuMetricCollectorScriptFolder}`); | ||
| try { | ||
| const pid: string = await fs.promises.readFile(path.join(this.gpuMetricCollectorScriptFolder, 'pid'), 'utf8'); |
There was a problem hiding this comment.
Suggest to consider how to show errors in NNI cleanup to end-user, but you can improve later after v0.6 release.
There was a problem hiding this comment.
ok, will refactor the logic in next release.
yds05
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.