This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix paiToken update logic #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Fix installation (microsoft#864)
merge master
merge master
merge master
merge master
Fix remote integration test pipeline (microsoft#914)
merge master
merge master
merge master
merge master
QuanluZhang
reviewed
Apr 15, 2019
| @@ -529,7 +529,14 @@ class PAITrainingService implements TrainingService { | |||
|
|
|||
| private async statusCheckingLoop(): Promise<void> { | |||
| while (!this.stopping) { | |||
| await this.updatePaiToken(); | |||
| try{ | |||
| await this.updatePaiToken(); | |||
There was a problem hiding this comment.
if timeout, there is no log written.
There was a problem hiding this comment.
if timeout, there is no log written.
when catch error, log it out here.
QuanluZhang
approved these changes
Apr 17, 2019
yds05
approved these changes
Apr 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When update paiToken after experiment is started, do not throw error.