This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Optimization of copy as python #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Apr 16, 2019
added 2 commits
April 16, 2019 12:36
SparkSnail
approved these changes
Apr 16, 2019
QuanluZhang
reviewed
Apr 16, 2019
| @@ -46,17 +46,17 @@ class SuccessTable extends React.Component<SuccessTableProps, {}> { | |||
|
|
|||
| let bgColor = ''; | |||
| const columns = [{ | |||
| title: 'Trial No.', | |||
| title: 'Trial no.', | |||
QuanluZhang
reviewed
Apr 16, 2019
| @@ -31,13 +31,13 @@ class LogPath extends React.Component<LogpathProps, {}> { | |||
| /> | |||
| <LogPathChild | |||
| eachLogpath={logStr.split(',')[1]} | |||
| logName="hdfsLogPath:" | |||
| logName="hdfs log path:" | |||
There was a problem hiding this comment.
so, also Log on HDFS?
QuanluZhang
reviewed
Apr 16, 2019
| /> | ||
| <LogPathChild | ||
| eachLogpath={logStr.split(',')[1]} | ||
| logName="hdfsLog:" | ||
| logName="hdfs log:" |
QuanluZhang
reviewed
Apr 16, 2019
| @@ -63,8 +63,8 @@ class DefaultPoint extends React.Component<DefaultPointProps, DefaultPointState> | |||
| }, | |||
| formatter: function (data: TooltipForAccuracy) { | |||
| const result = '<div class="tooldetailAccuracy">' + | |||
| '<div>Trial No: ' + data.data[0] + '</div>' + | |||
| '<div>Default Metric: ' + data.data[1] + '</div>' + | |||
| '<div>Trial no: ' + data.data[0] + '</div>' + | |||
QuanluZhang
reviewed
Apr 16, 2019
| @@ -131,13 +131,13 @@ class TableList extends React.Component<TableListProps, TableListState> { | |||
| const wantResult: Array<string> = []; | |||
| Object.keys(checkedValues).map(m => { | |||
| switch (checkedValues[m]) { | |||
| case 'Trial No.': | |||
| case 'Id': | |||
| case 'Trial no.': | |||
QuanluZhang
reviewed
Apr 16, 2019
| @@ -109,7 +109,7 @@ class Intermediate extends React.Component<IntermediateProps, IntermediateState> | |||
| obj = temp.hyperPara; | |||
| } | |||
| return '<div class="tooldetailAccuracy">' + | |||
| '<div>Trial Id: ' + trialId + '</div>' + | |||
| '<div>Trial id: ' + trialId + '</div>' + | |||
QuanluZhang
reviewed
Apr 16, 2019
| @@ -226,9 +226,9 @@ class TableList extends React.Component<TableListProps, TableListState> { | |||
| Object.keys(columnSelected).map(key => { | |||
| const item = columnSelected[key]; | |||
| switch (item) { | |||
| case 'Trial No.': | |||
| case 'Trial no.': | |||
QuanluZhang
reviewed
Apr 16, 2019
| showColumn.push({ | ||
| title: 'Trial No.', | ||
| title: 'Trial no.', |
QuanluZhang
reviewed
Apr 16, 2019
src/webui/src/static/const.ts
Outdated
| @@ -21,11 +21,11 @@ const MONACO = { | |||
| }; | |||
| const COLUMN_INDEX = [ | |||
| { | |||
| name: 'Trial No.', | |||
| name: 'Trial no.', | |||
QuanluZhang
reviewed
Apr 16, 2019
src/webui/src/static/const.ts
Outdated
| index: 10001 | ||
| } | ||
| ]; | ||
| const COLUMN = ['Trial No.', 'Id', 'Duration', 'Status', 'Default', 'Operation', 'Intermediate Result']; | ||
| const COLUMN = ['Trial no.', 'ID', 'Duration', 'Status', 'Default', 'Operation', 'Intermediate result']; |
SparkSnail
reviewed
Apr 16, 2019
| <Row className="basic colorOfbasic"> | ||
| <p>succeed</p> | ||
| <p>Succeed</p> |
lvybriage
changed the title
QuanluZhang
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#904 copy trial parameters
delete control page code
some style change: