From e8ff5f01b50da843135d6e44abeed30f3b86c5e1 Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Thu, 5 Aug 2021 17:05:01 -0400 Subject: [PATCH 1/5] address clippy warnings --- src/agent/win-util/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/agent/win-util/src/lib.rs b/src/agent/win-util/src/lib.rs index be4df332cd..fd6f3e665c 100644 --- a/src/agent/win-util/src/lib.rs +++ b/src/agent/win-util/src/lib.rs @@ -65,8 +65,8 @@ pub fn configure_machine_wide_app_debug_settings(application_path: impl AsRef Date: Thu, 5 Aug 2021 19:43:08 -0400 Subject: [PATCH 2/5] another clippy warning --- src/agent/debugger/src/breakpoint.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agent/debugger/src/breakpoint.rs b/src/agent/debugger/src/breakpoint.rs index 239e2bb61a..30ae0ce6e5 100644 --- a/src/agent/debugger/src/breakpoint.rs +++ b/src/agent/debugger/src/breakpoint.rs @@ -275,7 +275,7 @@ impl BreakpointCollection { } fn bulk_write_process_memory(&self, process_handle: HANDLE, buffer: &[u8]) -> Result<()> { - process::write_memory_slice(process_handle, self.min_breakpoint_addr as _, &buffer)?; + process::write_memory_slice(process_handle, self.min_breakpoint_addr as _, buffer)?; process::flush_instruction_cache( process_handle, self.min_breakpoint_addr as _, From 0d6e0118e2bad8ab1299dd2eff58d445a51554db Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Fri, 6 Aug 2021 08:32:53 -0400 Subject: [PATCH 3/5] more clippy warnings --- src/agent/coverage/src/block/pe_provider.rs | 2 +- src/agent/coverage/src/pe.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/agent/coverage/src/block/pe_provider.rs b/src/agent/coverage/src/block/pe_provider.rs index 4ec76bdc6d..baa5f0e625 100644 --- a/src/agent/coverage/src/block/pe_provider.rs +++ b/src/agent/coverage/src/block/pe_provider.rs @@ -73,7 +73,7 @@ where // reverse the instrumented basic blocks. fn provide_from_inline_table(&mut self, inline_table: SancovTable) -> Result> { let mut visitor = - SancovInlineAccessVisitor::new(inline_table, &self.data, &self.pe, &mut self.pdb)?; + SancovInlineAccessVisitor::new(inline_table, self.data, self.pe, &mut self.pdb)?; let debug_info = self.pdb.debug_information()?; let mut modules = debug_info.modules()?; diff --git a/src/agent/coverage/src/pe.rs b/src/agent/coverage/src/pe.rs index 808761d7c5..932520af99 100644 --- a/src/agent/coverage/src/pe.rs +++ b/src/agent/coverage/src/pe.rs @@ -259,7 +259,7 @@ fn process_pdb(data: &[u8], pe: &PE, functions_only: bool, pdb_path: &Path) -> R &proc_sym_info[..], &mut blocks, &address_map, - &pe, + pe, data, functions_only, )?; @@ -274,7 +274,7 @@ fn process_pdb(data: &[u8], pe: &PE, functions_only: bool, pdb_path: &Path) -> R &proc_sym_info[..], &mut blocks, &address_map, - &pe, + pe, data, functions_only, )?; From 8f85bb12c732c3421314676c3e95ba3535ac4992 Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Fri, 6 Aug 2021 08:33:38 -0400 Subject: [PATCH 4/5] bump rust cache key --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5cfdee8425..6d2f22d867 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ env: CARGO_TERM_COLOR: always SCCACHE_DIR: ${{github.workspace}}/sccache/ SCCACHE_CACHE_SIZE: 1G - ACTIONS_CACHE_KEY_DATE: 2021-08-02-01 + ACTIONS_CACHE_KEY_DATE: 2021-08-06-01 jobs: agent: From 4da6e1b3278aafc159873b898263bd2d7a9bd779 Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Fri, 6 Aug 2021 09:11:44 -0400 Subject: [PATCH 5/5] more clippy --- src/agent/input-tester/src/tester.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/agent/input-tester/src/tester.rs b/src/agent/input-tester/src/tester.rs index c294101d01..5fcce19b82 100644 --- a/src/agent/input-tester/src/tester.rs +++ b/src/agent/input-tester/src/tester.rs @@ -263,7 +263,7 @@ impl Tester { .context("Writing markdown summary for crash/timeout.")?; // Create a batch file to help reproduce the bug with the settings we used. - self.create_repro_bat(&log_dir, &result.input_path, &deduped_input_path)?; + self.create_repro_bat(log_dir, &result.input_path, deduped_input_path)?; Ok(()) } @@ -389,7 +389,7 @@ impl Tester { "{}-logs", logs_dir.file_stem().unwrap().to_string_lossy() )); - self.create_test_failure_artifacts(&logs_dir, &result, &copied_file)?; + self.create_test_failure_artifacts(&logs_dir, result, &copied_file)?; Ok(Some(new_test_result( result.debugger_result.clone(), &result.input_path,