This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Deserialize user info when pulling from blob #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
commented
May 8, 2023
mgreisen
approved these changes
May 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
+ Coverage 31.75% 32.95% +1.19%
==========================================
Files 307 180 -127
Lines 36770 22886 -13884
==========================================
- Hits 11678 7542 -4136
+ Misses 25092 15344 -9748 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Our user info serializer fails when reading. We know though, that reading from the events container (which is controlled by onefuzz and only written to by onefuzz_ is safe. So this PR adds a special case when deserializing events from the events container.
Validation Steps Performed
How does someone test & validate?
Added integration test that specifically exercises the failing code path.