This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Include all loader errors when failing #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3509 +/- ##
==========================================
- Coverage 39.06% 39.04% -0.02%
==========================================
Files 302 302
Lines 36904 36916 +12
==========================================
Hits 14415 14415
- Misses 22489 22501 +12
|
Porges
force-pushed
the
report-all-loader-errors
branch
from
4193abb to
31f31bd
Compare
tevoinea
reviewed
Oct 10, 2023
tevoinea
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2736.
Include all errors from the loader transcript when looking for missing DLLs. This will help users to analyze the problem, as this information can include missing symbols, etc.