This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Scoped notification pause #3579
Merged
tevoinea
merged 13 commits into
microsoft:main
from
tevoinea:tevoinea/ScopedNotificationPause
Oct 30, 2023
Merged
Scoped notification pause #3579
tevoinea
merged 13 commits into
microsoft:main
from
tevoinea:tevoinea/ScopedNotificationPause
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inea/ScopedNotificationPause
Codecov Report
@@ Coverage Diff @@
## main #3579 +/- ##
==========================================
- Coverage 39.99% 39.94% -0.05%
==========================================
Files 303 303
Lines 37683 37724 +41
Branches 1728 1738 +10
==========================================
- Hits 15072 15070 -2
- Misses 22289 22332 +43
Partials 322 322
|
chkeita
reviewed
Oct 24, 2023
chkeita
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Info on Pull Request
What does this include?
onefuzz containers update {container name} {metadata key}={metadata value}
)ADO_WORKITEM_PROCESSING_DISABLED
have their retry count incremented. We should only increment the retry count when we actually try to process the notificationpauseNotifications=true
. If that's the case, requeue the message with a 1 day timeoutValidation Steps Performed
How does someone test & validate?
Tested in dev deployment: