From 7035600055ee222d458079fc9ab82ff8d9948991 Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Mon, 29 Mar 2021 17:00:36 -0400 Subject: [PATCH] set expect_crash_on_failure default to False on libFuzzer tasks --- .../__app__/onefuzzlib/job_templates/defaults/libfuzzer.py | 2 +- src/cli/onefuzz/templates/libfuzzer.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/api-service/__app__/onefuzzlib/job_templates/defaults/libfuzzer.py b/src/api-service/__app__/onefuzzlib/job_templates/defaults/libfuzzer.py index 299ae54cc6..55af40d5b0 100644 --- a/src/api-service/__app__/onefuzzlib/job_templates/defaults/libfuzzer.py +++ b/src/api-service/__app__/onefuzzlib/job_templates/defaults/libfuzzer.py @@ -261,7 +261,7 @@ name="expect_crash_on_failure", help="Require crashes upon non-zero exits from libfuzzer", type=UserFieldType.Bool, - default=True, + default=False, locations=[ UserFieldLocation( op=UserFieldOperation.add, diff --git a/src/cli/onefuzz/templates/libfuzzer.py b/src/cli/onefuzz/templates/libfuzzer.py index e90b64ff07..3f4adfdf54 100644 --- a/src/cli/onefuzz/templates/libfuzzer.py +++ b/src/cli/onefuzz/templates/libfuzzer.py @@ -210,7 +210,7 @@ def basic( colocate_all_tasks: bool = False, colocate_secondary_tasks: bool = True, check_fuzzer_help: bool = True, - expect_crash_on_failure: bool = True, + expect_crash_on_failure: bool = False, minimized_stack_depth: Optional[int] = None, ) -> Optional[Job]: """