From 6457a768408193b6cc6c5bdc6bf6f34e2dd7e222 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 23 Dec 2025 11:12:53 +0100 Subject: [PATCH 1/2] test: improve shard balancing --- .github/workflows/tests_primary.yml | 4 +- .../stable-test-runner/package-lock.json | 46 +++++++++---------- .../stable-test-runner/package.json | 2 +- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml index c87282654348c..a502a0d372be4 100644 --- a/.github/workflows/tests_primary.yml +++ b/.github/workflows/tests_primary.yml @@ -119,8 +119,8 @@ jobs: - uses: ./.github/actions/run-test with: node-version: ${{matrix.node-version}} - command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} - bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shardIndex }}" + command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --shard-weights=55:45 + bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}" flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }} diff --git a/tests/playwright-test/stable-test-runner/package-lock.json b/tests/playwright-test/stable-test-runner/package-lock.json index 5f1aeca2f1519..cc5615a0b0b4d 100644 --- a/tests/playwright-test/stable-test-runner/package-lock.json +++ b/tests/playwright-test/stable-test-runner/package-lock.json @@ -5,16 +5,16 @@ "packages": { "": { "dependencies": { - "@playwright/test": "^1.58.0-alpha-2025-12-15" + "@playwright/test": "^1.58.0-alpha-1766484475000" } }, "node_modules/@playwright/test": { - "version": "1.58.0-alpha-2025-12-15", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.58.0-alpha-2025-12-15.tgz", - "integrity": "sha512-Mefy7ak8IF13cyzmQBp1W2CEDtvIcHuEtvvHYR99qiGC5XtchRrvGcHbaTIqOqIa5ylUV4cRF2Tc95lFvi/Uzg==", + "version": "1.58.0-alpha-1766484475000", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.58.0-alpha-1766484475000.tgz", + "integrity": "sha512-8Oqb2qt/cePXHl0Q5FP1oGiRPmewcLkLMyOxvtwSVDVVjo6dbfkOmVMqWMol2FUzz8fCToi0KNAdYETQrNKVkQ==", "license": "Apache-2.0", "dependencies": { - "playwright": "1.58.0-alpha-2025-12-15" + "playwright": "1.58.0-alpha-1766484475000" }, "bin": { "playwright": "cli.js" @@ -38,12 +38,12 @@ } }, "node_modules/playwright": { - "version": "1.58.0-alpha-2025-12-15", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.58.0-alpha-2025-12-15.tgz", - "integrity": "sha512-JYLfC3gBvT4ehp571cKGM9D5fUS72hJB5z3tQZhb07mXF83O8ACwD5MjUodK7PSsWpFdzAZdBkN+ViGfxuqmGg==", + "version": "1.58.0-alpha-1766484475000", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.58.0-alpha-1766484475000.tgz", + "integrity": "sha512-m3uweforLXbu4FzQj7IxAy03PJtvslhzdvPcNH9cYc+uKBzlr7w0vmKQ01mkVNt//FXm3XVuE8zvfrb2vVWg5g==", "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.58.0-alpha-2025-12-15" + "playwright-core": "1.58.0-alpha-1766484475000" }, "bin": { "playwright": "cli.js" @@ -56,9 +56,9 @@ } }, "node_modules/playwright-core": { - "version": "1.58.0-alpha-2025-12-15", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.58.0-alpha-2025-12-15.tgz", - "integrity": "sha512-gVslWs/nxAyAE8G/cWtwwSgDY8T18xXat2eSzlu/x5FNzw+P+Mr1sUdZ3dc5WIiYZwJqligYllJgaVQvOg9uEg==", + "version": "1.58.0-alpha-1766484475000", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.58.0-alpha-1766484475000.tgz", + "integrity": "sha512-hClfYK18Fr52LcJb8FTeeWaXyPq6ybXKL0f/0AdgHYQrWeXUmOc+VrLlN+ebD5mHMYWiJbOQyIGP5EepMCSNEw==", "license": "Apache-2.0", "bin": { "playwright-core": "cli.js" @@ -70,11 +70,11 @@ }, "dependencies": { "@playwright/test": { - "version": "1.58.0-alpha-2025-12-15", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.58.0-alpha-2025-12-15.tgz", - "integrity": "sha512-Mefy7ak8IF13cyzmQBp1W2CEDtvIcHuEtvvHYR99qiGC5XtchRrvGcHbaTIqOqIa5ylUV4cRF2Tc95lFvi/Uzg==", + "version": "1.58.0-alpha-1766484475000", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.58.0-alpha-1766484475000.tgz", + "integrity": "sha512-8Oqb2qt/cePXHl0Q5FP1oGiRPmewcLkLMyOxvtwSVDVVjo6dbfkOmVMqWMol2FUzz8fCToi0KNAdYETQrNKVkQ==", "requires": { - "playwright": "1.58.0-alpha-2025-12-15" + "playwright": "1.58.0-alpha-1766484475000" } }, "fsevents": { @@ -84,18 +84,18 @@ "optional": true }, "playwright": { - "version": "1.58.0-alpha-2025-12-15", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.58.0-alpha-2025-12-15.tgz", - "integrity": "sha512-JYLfC3gBvT4ehp571cKGM9D5fUS72hJB5z3tQZhb07mXF83O8ACwD5MjUodK7PSsWpFdzAZdBkN+ViGfxuqmGg==", + "version": "1.58.0-alpha-1766484475000", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.58.0-alpha-1766484475000.tgz", + "integrity": "sha512-m3uweforLXbu4FzQj7IxAy03PJtvslhzdvPcNH9cYc+uKBzlr7w0vmKQ01mkVNt//FXm3XVuE8zvfrb2vVWg5g==", "requires": { "fsevents": "2.3.2", - "playwright-core": "1.58.0-alpha-2025-12-15" + "playwright-core": "1.58.0-alpha-1766484475000" } }, "playwright-core": { - "version": "1.58.0-alpha-2025-12-15", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.58.0-alpha-2025-12-15.tgz", - "integrity": "sha512-gVslWs/nxAyAE8G/cWtwwSgDY8T18xXat2eSzlu/x5FNzw+P+Mr1sUdZ3dc5WIiYZwJqligYllJgaVQvOg9uEg==" + "version": "1.58.0-alpha-1766484475000", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.58.0-alpha-1766484475000.tgz", + "integrity": "sha512-hClfYK18Fr52LcJb8FTeeWaXyPq6ybXKL0f/0AdgHYQrWeXUmOc+VrLlN+ebD5mHMYWiJbOQyIGP5EepMCSNEw==" } } } diff --git a/tests/playwright-test/stable-test-runner/package.json b/tests/playwright-test/stable-test-runner/package.json index 8efc2e1de3149..38fbbdd5790b7 100644 --- a/tests/playwright-test/stable-test-runner/package.json +++ b/tests/playwright-test/stable-test-runner/package.json @@ -1,6 +1,6 @@ { "private": true, "dependencies": { - "@playwright/test": "^1.58.0-alpha-2025-12-15" + "@playwright/test": "^1.58.0-alpha-1766484475000" } } From 37ff00857935c3d1c3f27c585ecd045a28b801f4 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 23 Dec 2025 11:52:42 +0100 Subject: [PATCH 2/2] give a little more to shard 1 --- .github/workflows/tests_primary.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml index a502a0d372be4..669c40841516a 100644 --- a/.github/workflows/tests_primary.yml +++ b/.github/workflows/tests_primary.yml @@ -119,8 +119,8 @@ jobs: - uses: ./.github/actions/run-test with: node-version: ${{matrix.node-version}} - command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --shard-weights=55:45 - bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}" + command: npm run ttest -- --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --shard-weights=58:42 + bot-name: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shardIndex }}" flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }} flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }} flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}