Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global phase -1, relative phase i, and complex relative phase tasks to Single-Qubit Gates kata #1369

Merged
merged 27 commits into from
Apr 11, 2024
Merged

Add global phase -1, relative phase i, and complex relative phase tasks to Single-Qubit Gates kata #1369

merged 27 commits into from
Apr 11, 2024

Conversation

WWhitedogi
Copy link
Contributor

add task phase_flip, phase_change, global phase_change to Single Qubit Gates

tcNickolas
tcNickolas requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I went through and left some formatting comments.

Thank you!

katas/content/single_qubit_gates/index.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/index.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/index.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/phase_flip/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/phase_change/index.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
WWhitedogi and others added 11 commits April 9, 2024 23:53
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/index.md
239bfb3 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/index.md
fc863fc 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/index.md
43229e1 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/phase_change/index.md
ed01519 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/phase_change/solution.md
24a60c8 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
f70bbca 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
6a1be52 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/index.md
afb2a51 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
a5014ab 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
3108ca3 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
6c46faf 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@tcNickolas
Copy link
Member

Can you let me know when this PR is ready for another round of review? Just leave a comment or "request review" so that I know to look at it again. Thank you!

tcNickolas
tcNickolas approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (And nice solution explanation rewrite!)
I left some formatting suggestions, but I should be able to click through them to accept them without you doing that before merging.

Thank you!

katas/content/single_qubit_gates/phase_flip/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/solution.md Outdated Show resolved Hide resolved
katas/content/single_qubit_gates/global_phase_change/Solution.qs Outdated Show resolved Hide resolved
WWhitedogi and others added 3 commits April 11, 2024 16:03
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/phase_flip/solution.md
2e116c1 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/phase_change/solution.md
6785853 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
46b04c9 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
WWhitedogi and others added 6 commits April 11, 2024 16:03
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
16e1766 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
92efb03 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
b652615 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
233ef29 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/solution.md
187c1b8 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@WWhitedogi @tcNickolas
Update katas/content/single_qubit_gates/global_phase_change/Solution.qs
8adfcac 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@tcNickolas tcNickolas changed the title “addtask1.5to1.7” Add global phase -1, relative phase i, and complex relative phase tasks to Single-Qubit Gates kata Apr 11, 2024
@tcNickolas tcNickolas enabled auto-merge April 11, 2024 20:20
@tcNickolas tcNickolas added this pull request to the merge queue Apr 11, 2024
Merged via the queue into microsoft:main with commit bb39c1e Apr 11, 2024
17 checks passed
@billti billti mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WWhitedogi @tcNickolas