Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Simplify dependencies handling for exercises in katas" #1640 #1674

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

ggridin
Copy link
Contributor

@ggridin ggridin commented Jun 27, 2024

Link to the issue: #1640

The following changes were done:

  1. qsDependencies property is no longer processing (generate_katas_content.js)
  2. ../KatasLibrary.qs is included as implicit dependency
  3. ./Common.qs is included as implicit dependency if present in current kata
  4. All qsDependencies properties are removed from index.md's
  5. README.md is updated - reference to qsDependencies is removed

Testing done:

  1. "Happy path": Windows cmd build: "python ./build.py --wasm --npm --play" - success
    Local playground manual testing - no impact (Chrome and Edge)
  2. No impact when qsDependencies are present in index.md
  3. No impact when qsDependencies are present and empty in index.md

Question: should Ubuntu build be tested?

@tcNickolas
Copy link
Member

Can you please sign the CLA? We need it to be able to accept your contribution

@ggridin
Copy link
Contributor Author

ggridin commented Jun 27, 2024

@microsoft-github-policy-service agree

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can't think of any additional scenarios to test that would not be caught by the multi-platform CI builds

Thank you!

Copy link
Contributor

@cesarzc cesarzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this contribution!

@tcNickolas tcNickolas added this pull request to the merge queue Jun 28, 2024
@tcNickolas tcNickolas linked an issue Jun 28, 2024 that may be closed by this pull request
Merged via the queue into microsoft:main with commit b973e65 Jun 28, 2024
16 checks passed
@ggridin ggridin deleted the dependencies1640 branch July 13, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify dependencies handling for exercises in katas
3 participants