-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitigate race condition in completion list triggering #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
requested review from
billti,
cesarzc,
sezna,
idavis and
ScottCarda-MS
as code owners
June 29, 2024 00:31
Benchmark for 13dcd88Click to view benchmark
|
ScottCarda-MS
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just adding a 50 ms delay to avoid the race condition.
sezna
approved these changes
Jul 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 11, 2024
Rerunning the jobs and re-queueing since a job timed out. |
Change in memory usage detected by benchmark. Memory Report for 13dcd88
|
Benchmark for 13dcd88Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to upcoming field access completion work - @ScottCarda-MS
I won't be here to see this PR to completion, so please merge when/if appropriate.