Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate race condition in completion list triggering #1682

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

minestarks
Copy link
Member

Relevant to upcoming field access completion work - @ScottCarda-MS

I won't be here to see this PR to completion, so please merge when/if appropriate.

Copy link

Benchmark for 13dcd88

Click to view benchmark
Test Base PR %
Array append evaluation 328.2±4.80µs 330.2±9.04µs +0.61%
Array literal evaluation 171.0±0.98µs 168.2±1.35µs -1.64%
Array update evaluation 405.7±4.57µs 409.5±12.47µs +0.94%
Core + Standard library compilation 20.9±0.75ms 20.6±0.55ms -1.44%
Deutsch-Jozsa evaluation 5.1±0.06ms 5.2±0.10ms +1.96%
Large file parity evaluation 34.4±0.16ms 34.4±0.44ms 0.00%
Large input file compilation 12.6±0.36ms 12.4±0.24ms -1.59%
Large input file compilation (interpreter) 49.8±0.96ms 48.9±1.11ms -1.81%
Large nested iteration 31.5±0.27ms 31.5±0.14ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1574.6±34.30µs 1569.6±39.37µs -0.32%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.07ms 7.9±0.34ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1436.5±52.57µs 1433.4±52.05µs -0.22%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.1±0.22ms 28.1±0.54ms 0.00%
Teleport evaluation 90.8±3.44µs 91.1±4.94µs +0.33%

Copy link
Contributor

@ScottCarda-MS ScottCarda-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just adding a 50 ms delay to avoid the race condition.

@ScottCarda-MS ScottCarda-MS added this pull request to the merge queue Jul 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 11, 2024
@sezna
Copy link
Contributor

sezna commented Jul 11, 2024

Rerunning the jobs and re-queueing since a job timed out.

@sezna sezna enabled auto-merge July 11, 2024 03:39
Copy link

Change in memory usage detected by benchmark.

Memory Report for 13dcd88

Test This Branch On Main Difference
compile core + standard lib 16689324 bytes 16755780 bytes -66456 bytes

Copy link

Benchmark for 13dcd88

Click to view benchmark
Test Base PR %
Array append evaluation 332.0±3.64µs 329.7±1.13µs -0.69%
Array literal evaluation 186.3±1.75µs 187.2±2.60µs +0.48%
Array update evaluation 411.8±2.54µs 411.7±2.02µs -0.02%
Core + Standard library compilation 21.6±0.61ms 20.0±0.24ms -7.41%
Deutsch-Jozsa evaluation 4.8±0.04ms 5.2±0.05ms +8.33%
Large file parity evaluation 34.2±0.23ms 34.4±0.21ms +0.58%
Large input file compilation 12.3±0.18ms 12.4±0.23ms +0.81%
Large input file compilation (interpreter) 50.6±3.17ms 48.9±1.83ms -3.36%
Large nested iteration 32.1±0.13ms 32.2±0.26ms +0.31%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1579.4±60.77µs 1566.5±33.41µs -0.82%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.09ms 7.9±0.21ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1437.2±49.18µs 1425.8±36.11µs -0.79%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.1±0.25ms 27.9±0.41ms -0.71%
Teleport evaluation 91.3±3.00µs 92.5±5.65µs +1.31%

@sezna sezna added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 089c27b Jul 11, 2024
19 checks passed
@sezna sezna deleted the minestarks/completion-character branch July 11, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants