Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include package alias in auto-opens for completions #1715

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Jul 9, 2024

auto-opens:

Screen.Recording.2024-07-09.at.9.58.08.AM.mov

fully qualified namespace paths:

Screen.Recording.2024-07-09.at.10.48.39.AM.mov

@sezna sezna marked this pull request as ready for review July 9, 2024 17:30
@sezna sezna marked this pull request as draft July 9, 2024 17:46
@sezna sezna force-pushed the alex/fix-completions branch from aa97ab0 to eb4c7ef Compare July 9, 2024 17:50
@microsoft microsoft deleted a comment from github-actions bot Jul 9, 2024
@sezna sezna marked this pull request as ready for review July 9, 2024 17:51
Copy link

github-actions bot commented Jul 9, 2024

Benchmark for 226058f

Click to view benchmark
Test Base PR %
Array append evaluation 339.1±2.80µs 334.0±1.26µs -1.50%
Array literal evaluation 186.2±0.75µs 177.9±1.94µs -4.46%
Array update evaluation 412.9±2.40µs 411.0±1.42µs -0.46%
Core + Standard library compilation 22.1±0.68ms 22.0±1.01ms -0.45%
Deutsch-Jozsa evaluation 4.8±0.05ms 4.8±0.04ms 0.00%
Large file parity evaluation 34.3±0.23ms 34.2±0.26ms -0.29%
Large input file compilation 13.0±0.70ms 12.6±0.33ms -3.08%
Large input file compilation (interpreter) 50.2±1.64ms 50.6±1.76ms +0.80%
Large nested iteration 32.6±1.14ms 31.9±0.26ms -2.15%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1581.3±95.71µs 1585.4±75.88µs +0.26%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.0±0.12ms 8.3±0.22ms +3.75%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1441.4±127.93µs 1427.6±43.10µs -0.96%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.5±1.81ms 28.2±0.67ms -1.05%
Teleport evaluation 91.5±3.21µs 91.5±3.21µs 0.00%

@billti
Copy link
Member

billti commented Jul 9, 2024

Nice! Videos of experience looks great. I'll let @swernli and @ScottCarda-MS give the thumbs up on the code changes. Thanks!

Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added functionality and implementation look good. I think the feedback from @ScottCarda-MS is worth capturing into an issue for follow up.

@sezna sezna added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 93bf0af Jul 11, 2024
21 checks passed
@sezna sezna deleted the alex/fix-completions branch July 11, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants