-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate nonlocal games: GHZ game classical #1783
Migrate nonlocal games: GHZ game classical #1783
Conversation
…://github.com/ggridin/qsharp into MigrateNonlocalGames-1596-task2-GHZ-classical
Questions for this PR:
Testing done: Build "python ./build.py" is successful
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like the tweak on the second task to allow everybody to use a different classical strategy, since we can do it easily with the new infrastructure!
I left some cosmetic comments, nothing major.
Thank you!
katas/content/nonlocal_games/ghz_classical_strategy/Verification.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/ghz_classical_strategy/solution.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
…://github.com/ggridin/qsharp into MigrateNonlocalGames-1596-task2-GHZ-classical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! (Apologies for the delay reviewing, trying to wrap as many things up as I can before disappearing until next week...)
Thank you!!
This looks great! Thanks for putting the time in to get this done! |
The link to the issue: #1596
This pull request is covering
This approach allow to create more complicated output like [true, false, false] or [r, DrawRandomBool(0.8), not t]