-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edit/run for kata examples - issue 591 #1829
Add edit/run for kata examples - issue 591 #1829
Conversation
@swernli Stefan, thank you for the phantom error root cause and monaco editor logic explanation. Testing done:
|
Follow-up questions:
The fix (most likely) should introduce a unique URI for samples and the linked code. |
@ggridin Thanks, this is looking good! Regarding the questions,
I think the dropdown for selecting profile on katas, both exercises and examples, is not necessary. They always run in Unrestricted and should remain that way.
Good catch! Yes, we should follow up on this and fix it, so an issue would be great. I think your suggestion will likely end up being right fix. |
A bug is found: example's syntax error message shows for all examples and exercises. The fix is WIP |
Sorry for the noise in converting it out of draft, meant to click the button to run the pipeline! |
After today's branch sync, the issue mentioned above is gone (not reproducible). |
Add the edit/run for kata examples.
This PR closes #591
Monaco editor model should have a unique URI (with few exceptions). So, either kata lesson ID or kata exercise ID is provided to the model. The Editor.tsx implementation is replacing "kataExercise" parameter with "kataSection" that contains both lesson.id and exercise.id.
The function parameter "key" is not in use and was removed.