Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing docs for diagnostic callables #1833

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented Aug 13, 2024

Fixes #1822

Copy link

Change in memory usage detected by benchmark.

Memory Report for 63d84f6

Test This Branch On Main Difference
compile core + standard lib 17965368 bytes 17962584 bytes 2784 bytes

Copy link

Benchmark for 63d84f6

Click to view benchmark
Test Base PR %
Array append evaluation 333.6±1.62µs 332.3±3.17µs -0.39%
Array literal evaluation 186.8±1.33µs 188.2±4.77µs +0.75%
Array update evaluation 415.5±1.85µs 412.5±1.68µs -0.72%
Core + Standard library compilation 22.0±0.17ms 22.0±0.32ms 0.00%
Deutsch-Jozsa evaluation 5.0±0.07ms 4.9±0.22ms -2.00%
Large file parity evaluation 34.5±0.27ms 34.3±0.13ms -0.58%
Large input file compilation 13.8±0.30ms 13.8±0.44ms 0.00%
Large input file compilation (interpreter) 51.3±1.56ms 51.7±1.75ms +0.78%
Large nested iteration 33.0±0.34ms 32.8±1.11ms -0.61%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1572.5±36.50µs 1559.2±32.49µs -0.85%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.18ms 7.7±0.10ms -1.28%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1432.4±29.04µs 1423.4±41.24µs -0.63%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.6±0.45ms 27.5±0.50ms -0.36%
Teleport evaluation 93.8±3.49µs 93.6±5.86µs -0.21%

Copy link

Change in memory usage detected by benchmark.

Memory Report for c31a8a3

Test This Branch On Main Difference
compile core + standard lib 17966496 bytes 17962736 bytes 3760 bytes

library/std/src/diagnostics.qs Outdated Show resolved Hide resolved
Copy link

Benchmark for c31a8a3

Click to view benchmark
Test Base PR %
Array append evaluation 336.0±9.93µs 335.2±1.79µs -0.24%
Array literal evaluation 192.2±1.44µs 198.7±4.05µs +3.38%
Array update evaluation 417.1±11.49µs 415.2±2.71µs -0.46%
Core + Standard library compilation 22.8±0.46ms 24.3±1.37ms +6.58%
Deutsch-Jozsa evaluation 5.0±0.06ms 5.0±0.05ms 0.00%
Large file parity evaluation 35.0±0.29ms 35.1±0.65ms +0.29%
Large input file compilation 14.6±0.58ms 14.8±0.49ms +1.37%
Large input file compilation (interpreter) 57.1±2.06ms 57.2±1.32ms +0.18%
Large nested iteration 33.0±0.77ms 33.4±1.10ms +1.21%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1576.4±56.64µs 1592.5±123.45µs +1.02%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.1±0.44ms 8.1±0.11ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1434.2±55.89µs 1443.9±81.30µs +0.68%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.8±0.89ms 28.1±0.40ms +1.08%
Teleport evaluation 95.0±3.76µs 93.3±3.59µs -1.79%

Copy link

Change in memory usage detected by benchmark.

Memory Report for 425146e

Test This Branch On Main Difference
compile core + standard lib 17966344 bytes 17962736 bytes 3608 bytes

@swernli swernli enabled auto-merge August 14, 2024 21:12
@swernli swernli added this pull request to the merge queue Aug 14, 2024
Copy link

Benchmark for 425146e

Click to view benchmark
Test Base PR %
Array append evaluation 339.6±18.02µs 337.8±3.95µs -0.53%
Array literal evaluation 174.9±1.72µs 175.0±1.35µs +0.06%
Array update evaluation 415.3±1.60µs 415.9±1.97µs +0.14%
Core + Standard library compilation 22.1±0.30ms 22.0±0.55ms -0.45%
Deutsch-Jozsa evaluation 5.0±0.06ms 5.0±0.21ms 0.00%
Large file parity evaluation 34.5±0.27ms 34.7±0.41ms +0.58%
Large input file compilation 13.7±0.40ms 13.6±0.20ms -0.73%
Large input file compilation (interpreter) 52.1±1.75ms 51.5±1.48ms -1.15%
Large nested iteration 32.9±0.71ms 33.1±0.14ms +0.61%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1559.9±31.33µs 1551.6±29.02µs -0.53%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.05ms 7.8±0.05ms -1.27%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1421.0±32.20µs 1417.3±37.67µs -0.26%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.6±0.17ms 27.6±0.82ms 0.00%
Teleport evaluation 93.3±3.91µs 92.6±3.69µs -0.75%

Merged via the queue into main with commit ef98e36 Aug 14, 2024
19 checks passed
@swernli swernli deleted the swernli/diagnostic-doc-fix branch August 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing API docs for CheckZero, CheckAllZero, DumpMachine
3 participants