Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Katas UI review - Preparing states #1847

Merged
merged 15 commits into from
Sep 5, 2024
Merged

Katas UI review - Preparing states #1847

merged 15 commits into from
Sep 5, 2024

Conversation

SoniaLopezBravo
Copy link
Contributor

No description provided.

tcNickolas
tcNickolas requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to have more issues than the previous ones relatively to the number of files. Please make sure that you're previewing the files to check that the edits don't introduce formatting issues, like the missing escape for % inside formulas, and that no new typos are introduced, like the missing spaces between "you" and the next word.

katas/content/preparing_states/all_bell_states/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/bell_state/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/controlled_rotation/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/controlled_rotation/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/even_sup_two_qubits_complex_phases/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/unequal_superposition/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/wstate_arbitrary/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/wstate_arbitrary/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/wstate_arbitrary/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/wstate_power_of_two/solution.md Outdated Show resolved Hide resolved
SoniaLopezBravo and others added 12 commits August 19, 2024 20:00
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/bell_state/solution.md
b48cb3d 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/controlled_rotation/solution.md
225ad7c 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/even_sup_two_qubits_complex_pha…
0e05aa0 
…ses/solution.md

Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/unequal_superposition/solution.md
34cdbd7 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/wstate_arbitrary/solution.md
88bcc25 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/even_sup_two_qubits_phase_flip/…
956b675 
…solution.md

Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/four_bitstrings/solution.md
906dbd7 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/wstate_power_of_two/solution.md
d166b5c 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/wstate_arbitrary/solution.md
f30f780 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo @tcNickolas
Update katas/content/preparing_states/parity_bitstrings/solution.md
be6aac5 
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
@SoniaLopezBravo
Feedback and "our"s typos
1c0a516
@SoniaLopezBravo
missing escape
df05b64
@SoniaLopezBravo
Copy link
Contributor Author

This PR seems to have more issues than the previous ones relatively to the number of files. Please make sure that you're previewing the files to check that the edits don't introduce formatting issues, like the missing escape for % inside formulas, and that no new typos are introduced, like the missing spaces between "you" and the next word.

@tcNickolas I appreciate the honesty in your comment 👍🏻 I got overconfident and reviewed this kata too fast, I'll be more careful next time.

tcNickolas
tcNickolas approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of suggestions.

Thank you!

katas/content/preparing_states/wstate_arbitrary/solution.md Outdated Show resolved Hide resolved
katas/content/preparing_states/wstate_arbitrary/solution.md Outdated Show resolved Hide resolved
katas/content/qec_shor/index.md Outdated Show resolved Hide resolved
@tcNickolas tcNickolas enabled auto-merge September 5, 2024 15:37
@tcNickolas tcNickolas added this pull request to the merge queue Sep 5, 2024
Merged via the queue into microsoft:main with commit 6ba4a39 Sep 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@tcNickolas tcNickolas tcNickolas approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoniaLopezBravo @tcNickolas @swernli