Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hints in python wrapper for noisy simulator. #1857

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

orpuente-MS
Copy link
Contributor

@orpuente-MS orpuente-MS commented Aug 19, 2024

Fixes some type hints in the python wrapper for the noisy simulators.

Copy link

Benchmark for 38ee5ee

Click to view benchmark
Test Base PR %
Array append evaluation 342.5±13.05µs 338.9±2.37µs -1.05%
Array literal evaluation 185.8±1.27µs 186.0±0.72µs +0.11%
Array update evaluation 421.7±17.11µs 417.1±2.40µs -1.09%
Core + Standard library compilation 23.7±0.80ms 22.7±0.77ms -4.22%
Deutsch-Jozsa evaluation 5.0±0.05ms 5.0±0.07ms 0.00%
Large file parity evaluation 34.3±0.09ms 34.3±0.52ms 0.00%
Large input file compilation 14.2±0.28ms 13.9±0.64ms -2.11%
Large input file compilation (interpreter) 56.3±1.98ms 52.8±3.13ms -6.22%
Large nested iteration 32.8±0.47ms 32.7±0.22ms -0.30%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1614.7±133.70µs 1569.3±27.47µs -2.81%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.1±0.16ms 7.9±0.09ms -2.47%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1473.7±131.80µs 1436.2±34.57µs -2.54%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.4±0.41ms 27.9±0.65ms -1.76%
Teleport evaluation 94.0±3.67µs 94.2±4.90µs +0.21%

Copy link

Benchmark for 1cf9bc2

Click to view benchmark
Test Base PR %
Array append evaluation 338.2±4.79µs 349.6±1.96µs +3.37%
Array literal evaluation 169.9±1.14µs 170.2±5.82µs +0.18%
Array update evaluation 414.9±1.42µs 422.5±1.88µs +1.83%
Core + Standard library compilation 25.0±1.75ms 26.8±0.95ms +7.20%
Deutsch-Jozsa evaluation 5.0±0.08ms 4.9±0.06ms -2.00%
Large file parity evaluation 34.4±0.10ms 34.4±0.13ms 0.00%
Large input file compilation 16.3±0.48ms 14.6±0.55ms -10.43%
Large input file compilation (interpreter) 58.8±2.20ms 60.7±2.05ms +3.23%
Large nested iteration 32.8±0.21ms 33.6±0.41ms +2.44%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1620.2±122.84µs 1650.9±144.94µs +1.89%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.2±0.21ms 8.4±0.19ms +2.44%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1487.4±169.51µs 1507.9±158.26µs +1.38%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.4±0.37ms 28.8±0.28ms +1.41%
Teleport evaluation 93.8±3.62µs 94.8±6.84µs +1.07%

@orpuente-MS orpuente-MS changed the title Fix sample_instrument type hint in python wrapper for noisy simulator. Fix type hints in python wrapper for noisy simulator. Aug 20, 2024
@sezna sezna added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit e6af3bd Aug 20, 2024
19 checks passed
@sezna sezna deleted the oscarpuente/fix-noisy-simulator-type-hint branch August 20, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants