Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDT field completions #1954

Merged
merged 1 commit into from
Oct 21, 2024
Merged

UDT field completions #1954

merged 1 commit into from
Oct 21, 2024

Conversation

minestarks
Copy link
Member

@minestarks minestarks commented Oct 9, 2024

Builds on #1947 .

Enables:

  1. Field access completions, for example:
let x = Complex(1.0, 2.0);
x.| 

At the cursor location indicated by |, completions should include Real since it's a field of Complex.

  1. Field assignment completions, for example:
struct Foo {
    bar: Int
}

new Foo { | }

Here, completions should include Bar.

@minestarks minestarks marked this pull request as ready for review October 9, 2024 00:35
Base automatically changed from minestarks/member-completions to main October 17, 2024 18:39
@minestarks minestarks force-pushed the minestarks/field-completions branch from 4b2e03f to a3352ce Compare October 17, 2024 19:39
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really appreciate the extra documentation and tests

github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
This change updates our root clippy config and removes the individual
overrides for `needless_raw_string_hashes`. It also preemptively allows
`unnecessary_wraps` in anticipation of #1954
@minestarks minestarks added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 29145c5 Oct 21, 2024
18 checks passed
@minestarks minestarks deleted the minestarks/field-completions branch October 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants