-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UDT field completions #1954
Merged
Merged
UDT field completions #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
requested review from
billti,
cesarzc,
sezna,
swernli,
idavis and
ScottCarda-MS
as code owners
October 9, 2024 00:35
minestarks
force-pushed
the
minestarks/field-completions
branch
from
October 17, 2024 19:39
4b2e03f
to
a3352ce
Compare
sezna
reviewed
Oct 17, 2024
sezna
reviewed
Oct 17, 2024
sezna
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really appreciate the extra documentation and tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
This change updates our root clippy config and removes the individual overrides for `needless_raw_string_hashes`. It also preemptively allows `unnecessary_wraps` in anticipation of #1954
idavis
approved these changes
Oct 17, 2024
ScottCarda-MS
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1947 .
Enables:
At the cursor location indicated by
|
, completions should includeReal
since it's a field ofComplex
.Here, completions should include
Bar
.