Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting NSBeep feedback on every keystroke when entering text into the standard TextInput component #683

Closed
vincentriemer opened this issue Jan 2, 2021 · 5 comments

Comments

@vincentriemer
Copy link

Environment

  1. react-native -v: N/A (master)
  2. npm ls react-native-macos:
react-native-macos@1000.0.0 /Users/vincentriemer/Workspace/react-native-macos
└── (empty)
  1. node -v: v14.15.3
  2. npm -v: 6.14.9
  3. yarn --version: 1.22.5
  4. xcodebuild -version:
Xcode 12.3
Build version 12C33
  1. MacOS version: 11.1

Issue

Ever since I upgraded react-native-macos to 0.63.4 I noticed that I've been getting NSBeep (I think that's where it comes from) audio feedback for every keystroke — most notably when entering text into a TextInput component.

Steps to Reproduce

  1. Checkout the master branch of react-native-macos & perform the standard instructions detailed in the repo's "Contributing Guidelines" in order to build RNTester.
  2. Build & launch RNTester
  3. Navigate to the TextInput section
  4. Enter text into any TextInput instance present.

Expected Behavior

The text should properly be entered without any extra audio feedback.

Actual Behavior

There's a "beep" (from my brief research it comes from the NSBeep class) on every keystroke.

Reproducible Demo

I've been able to reproduce on the latest master branch of react-native-macos's RNTester project.

@ghost ghost added the Needs: Triage 🔍 label Jan 2, 2021
@ospfranco
Copy link

ospfranco commented Jan 6, 2021

This is only happening on development builds for me, once the app is packaged it works fine

I tested it again and I'm getting beeps as well

@chrisglein chrisglein added Area: TextInput bug Something isn't working and removed Needs: Triage 🔍 labels Jan 20, 2021
@chrisglein
Copy link
Member

There was a change to expand keyboard accessibility that may have caused a side effect here. The timeline could line up. @HeyImChris can you link the PR for that?

@HeyImChris
Copy link

Yea this seems related to this keyboard support fix made back in mid December

@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 18, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants