Fix detox yarn error with Xcode 12 #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream into fork
harrieshin
approved these changes
Dec 9, 2020
amgleitman
approved these changes
Dec 9, 2020
|
Pushing in- only failure was in the android ci with a known break (pom file) and this is an Apple fix. |
HeyImChris
added a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Dec 11, 2020
* Update RCTCxxBridge.mm * fix detox errors with xcode 12
HeyImChris
added a commit
that referenced
this pull request
Dec 12, 2020
* Update RCTCxxBridge.mm * macOS keyboard support * update comment * add key value checks so we don't send all events * macOS keyboard support * update comment * add key value checks so we don't send all events * [ado] Workaround homebrew openssl issue (#669) actions/runner-images#1811 (comment) * Fix detox yarn error with Xcode 12 (#670) * Update RCTCxxBridge.mm * fix detox errors with xcode 12 * only use valid keys, bubble events to super * macOS keyboard support * update comment * add key value checks so we don't send all events * only use valid keys, bubble events to super * macOS keyboard support * add key value checks so we don't send all events * resolve bad merge * update valid key bug, api typo * spacing fix * fix flow errors * fix snapshot tests for new APIs * yarn lint --fix * fix flipper Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
amgleitman
added a commit
to amgleitman/react-native-macos
that referenced
this pull request
Dec 14, 2020
harrieshin
pushed a commit
that referenced
this pull request
Dec 16, 2020
* Update RCTCxxBridge.mm * fix detox errors with xcode 12
harrieshin
pushed a commit
that referenced
this pull request
Dec 16, 2020
* Update RCTCxxBridge.mm * macOS keyboard support * update comment * add key value checks so we don't send all events * macOS keyboard support * update comment * add key value checks so we don't send all events * [ado] Workaround homebrew openssl issue (#669) actions/runner-images#1811 (comment) * Fix detox yarn error with Xcode 12 (#670) * Update RCTCxxBridge.mm * fix detox errors with xcode 12 * only use valid keys, bubble events to super * macOS keyboard support * update comment * add key value checks so we don't send all events * only use valid keys, bubble events to super * macOS keyboard support * add key value checks so we don't send all events * resolve bad merge * update valid key bug, api typo * spacing fix * fix flow errors * fix snapshot tests for new APIs * yarn lint --fix * fix flipper Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Detox is failing to install dependencies correctly as we're still using a version incompatible with Xcode 12. This updates to a newer version that runs correctly.
Changelog
[iOS/macOS] [Bug] - Fix detox failures with
yarndependenciesTest Plan
Ran
yarnwithout this and hit some detox failures. Ranyarnwith this and everything installed correctly.Microsoft Reviewers: Open in CodeFlow