Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android CI #674

Merged
merged 13 commits into from
Dec 12, 2020
Merged

Fix Android CI #674

merged 13 commits into from
Dec 12, 2020

Conversation

HeyImChris
Copy link

@HeyImChris HeyImChris commented Dec 12, 2020 •
edited
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Android CI is failing to build a nuget with an error about not being able to repeat build numbers... this is not a long term solution but try disabling the Android check that is correctly telling us android is failing to produce a nuget. This will at least unblock macOS and iOS builds from succeeding.

Changelog

[Android] [Fix] - fix ci build break

Test Plan

Validate in the CI

Microsoft Reviewers: Open in CodeFlow

HeyImChris and others added 10 commits May 14, 2020 15:03
@HeyImChris
Update RCTCxxBridge.mm
8df39e1
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
4a9bcbd
@HeyImChris
Merge pull request #1 from microsoft/master
e8d2d8b 
Merge upstream into fork
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
ab71c3b
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
e40c784
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
204ddb3
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
a76bcc1
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
7d85560
@HeyImChris
Merge branch 'master' of https://github.com/microsoft/react-native-macos
7011dc4
@HeyImChris
change the build number
94bc95b
@HeyImChris HeyImChris requested a review from alloy as a code owner December 12, 2020 20:46
@HeyImChris HeyImChris merged commit f33110a into microsoft:master Dec 12, 2020
harrieshin pushed a commit that referenced this pull request Dec 16, 2020
@HeyImChris @harrieshin
Fix Android CI (#674)
c916895 
* Update RCTCxxBridge.mm

* change the build number

* remove pom script

* disable android nuget check

* remove pom
amgleitman pushed a commit to amgleitman/react-native-macos that referenced this pull request Dec 16, 2020
@HeyImChris @amgleitman
cherry pick f33110a: Fix Android CI (microsoft#674)
9d47e0a
@amgleitman amgleitman mentioned this pull request Dec 16, 2020
Merged
4 tasks
harrieshin pushed a commit that referenced this pull request Dec 16, 2020
@amgleitman @HeyImChris
Cherry pick a few commits for 0.62-stable (#676)
0f0cc5e 
* cherry pick 63d3aff: Fix detox yarn error with Xcode 12 (#670)

* cherry pick a2f4df1: Disable redboxing on release builds (#671)

* cherry pick f33110a: Fix Android CI (#674)

Co-authored-by: HeyImChris <48299693+HeyImChris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrajeswaran anandrajeswaran anandrajeswaran approved these changes

@alloy alloy Awaiting requested review from alloy

@harrieshin harrieshin Awaiting requested review from harrieshin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeyImChris @anandrajeswaran